From: Jeff Law <jeffreyalaw@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] RTL: Merge rtx_equal_p and hash_rtx functions with their callback variants
Date: Sat, 17 Jun 2023 10:51:48 -0600 [thread overview]
Message-ID: <c7129b52-9fbb-509a-e91a-78e064249a02@gmail.com> (raw)
In-Reply-To: <CAFULd4ZZpOzdCPBz84zEYCiakXn6b5Hr=ae=-_un5z26erWO4Q@mail.gmail.com>
On 6/14/23 04:15, Uros Bizjak via Gcc-patches wrote:
> Use default argument when callback function is not required to merge
> rtx_equal_p and hash_rtx functions with their callback variants.
>
> gcc/ChangeLog:
>
> * cse.cc (hash_rtx_cb): Rename to hash_rtx.
> (hash_rtx): Remove.
> * early-remat.cc (remat_candidate_hasher::equal): Update
> to call rtx_equal_p with rtx_equal_p_callback_function argument.
> * rtl.cc (rtx_equal_p_cb): Rename to rtx_equal_p.
> (rtx_equal_p): Remove.
> * rtl.h (rtx_equal_p): Add rtx_equal_p_callback_function
> argument with NULL default value.
> (rtx_equal_p_cb): Remove function declaration.
> (hash_rtx_cb): Ditto.
> (hash_rtx): Add hash_rtx_callback_function argument
> with NULL default value.
> * sel-sched-ir.cc (free_nop_pool): Update function comment.
> (skip_unspecs_callback): Ditto.
> (vinsn_init): Update to call hash_rtx with
> hash_rtx_callback_function argument.
> (vinsn_equal_p): Ditto.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>
> OK for master?
OK
jeff
prev parent reply other threads:[~2023-06-17 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:15 Uros Bizjak
2023-06-17 16:51 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7129b52-9fbb-509a-e91a-78e064249a02@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).