From: Jeff Law <jlaw@ventanamicro.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] Fix comment typos noticed by Bernhard
Date: Tue, 22 Nov 2022 16:38:50 -0700 [thread overview]
Message-ID: <c7a10aaa-bd50-9243-c9b2-ef3d2f98f516@ventanamicro.com> (raw)
In-Reply-To: <CA+=Sn1k=p1pACi4HEPrnkXRwMHUprbkaoaVovorbUmVeudpgwA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On 11/22/22 16:28, Andrew Pinski wrote:
> On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote:
>> Minor comment typo fixes as noticed by Bernhard.
>>
>>
>> Installed onto the trunk,
> Hmm:
> - int alternative
> + int bool
>
> That seems wrong and might cause a build failure.
Fixed thusly.
jeff
ps. I keep thinking that the workflow right now is fairly cumbersome
moving things between the laptop and one of the servers I use. I could
make an argument that a topic branch with a merge-request would be
better. But we're not set up for that :(
[-- Attachment #2: P --]
[-- Type: text/plain, Size: 745 bytes --]
commit ee86077c2c2e38376cb5a575af62e9187c98e8df
Author: Jeff Law <jlaw@ventanamicro.com>
Date: Tue Nov 22 16:30:38 2022 -0700
Fix thinko in last patch
gcc/
* tree-ssa-dom.cc (record_edge_info): Fix thinko in last commit.
diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc
index e82f4f73a66..c9e52d1ee94 100644
--- a/gcc/tree-ssa-dom.cc
+++ b/gcc/tree-ssa-dom.cc
@@ -676,7 +676,7 @@ record_edge_info (basic_block bb)
if it never traverses the backedge to begin with. This
implies that any PHI nodes create equivalances that we
can attach to the loop exit edge. */
- int bool
+ bool alternative
= (EDGE_PRED (bb, 0)->flags & EDGE_DFS_BACK) ? 1 : 0;
gphi_iterator gsi;
prev parent reply other threads:[~2022-11-22 23:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 23:24 Jeff Law
2022-11-22 23:28 ` Andrew Pinski
2022-11-22 23:32 ` Jeff Law
2022-11-22 23:38 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a10aaa-bd50-9243-c9b2-ef3d2f98f516@ventanamicro.com \
--to=jlaw@ventanamicro.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).