* [committed] Fix comment typos noticed by Bernhard
@ 2022-11-22 23:24 Jeff Law
2022-11-22 23:28 ` Andrew Pinski
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2022-11-22 23:24 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 86 bytes --]
Minor comment typo fixes as noticed by Bernhard.
Installed onto the trunk,
Jeff
[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1037 bytes --]
commit a03b35a28db262546415e8f16829cbb027a75025
Author: Jeff Law <jlaw@ventanamicro.com>
Date: Tue Nov 22 16:22:18 2022 -0700
Fix comment typos noticed by Bernhard
gcc/
* tree-ssa-dom.cc (record_edge_info): Fix comment typos.
diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc
index c7f095d79fc..e82f4f73a66 100644
--- a/gcc/tree-ssa-dom.cc
+++ b/gcc/tree-ssa-dom.cc
@@ -673,10 +673,10 @@ record_edge_info (basic_block bb)
{
/* At this point we know the exit condition is loop
invariant. The only way to get out of the loop is
- if never traverses the backedge to begin with. This
- implies that any PHI nodes create equivalances we can
- attach to the loop exit edge. */
- int alternative
+ if it never traverses the backedge to begin with. This
+ implies that any PHI nodes create equivalances that we
+ can attach to the loop exit edge. */
+ int bool
= (EDGE_PRED (bb, 0)->flags & EDGE_DFS_BACK) ? 1 : 0;
gphi_iterator gsi;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed] Fix comment typos noticed by Bernhard
2022-11-22 23:24 [committed] Fix comment typos noticed by Bernhard Jeff Law
@ 2022-11-22 23:28 ` Andrew Pinski
2022-11-22 23:32 ` Jeff Law
2022-11-22 23:38 ` Jeff Law
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Pinski @ 2022-11-22 23:28 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches
On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote:
>
> Minor comment typo fixes as noticed by Bernhard.
>
>
> Installed onto the trunk,
Hmm:
- int alternative
+ int bool
That seems wrong and might cause a build failure.
Thanks,
Andrew
>
>
> Jeff
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed] Fix comment typos noticed by Bernhard
2022-11-22 23:28 ` Andrew Pinski
@ 2022-11-22 23:32 ` Jeff Law
2022-11-22 23:38 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2022-11-22 23:32 UTC (permalink / raw)
To: Andrew Pinski; +Cc: gcc-patches
On 11/22/22 16:28, Andrew Pinski wrote:
> On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote:
>> Minor comment typo fixes as noticed by Bernhard.
>>
>>
>> Installed onto the trunk,
> Hmm:
> - int alternative
> + int bool
>
> That seems wrong and might cause a build failure.
Ugh. Probably will. I'll double-check momentarily. That's what I get
for scanning the stashed patch thinking it was just comment fixes and
not bootstrapping. My bad entirely.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed] Fix comment typos noticed by Bernhard
2022-11-22 23:28 ` Andrew Pinski
2022-11-22 23:32 ` Jeff Law
@ 2022-11-22 23:38 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2022-11-22 23:38 UTC (permalink / raw)
To: Andrew Pinski; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On 11/22/22 16:28, Andrew Pinski wrote:
> On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote:
>> Minor comment typo fixes as noticed by Bernhard.
>>
>>
>> Installed onto the trunk,
> Hmm:
> - int alternative
> + int bool
>
> That seems wrong and might cause a build failure.
Fixed thusly.
jeff
ps. I keep thinking that the workflow right now is fairly cumbersome
moving things between the laptop and one of the servers I use. I could
make an argument that a topic branch with a merge-request would be
better. But we're not set up for that :(
[-- Attachment #2: P --]
[-- Type: text/plain, Size: 745 bytes --]
commit ee86077c2c2e38376cb5a575af62e9187c98e8df
Author: Jeff Law <jlaw@ventanamicro.com>
Date: Tue Nov 22 16:30:38 2022 -0700
Fix thinko in last patch
gcc/
* tree-ssa-dom.cc (record_edge_info): Fix thinko in last commit.
diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc
index e82f4f73a66..c9e52d1ee94 100644
--- a/gcc/tree-ssa-dom.cc
+++ b/gcc/tree-ssa-dom.cc
@@ -676,7 +676,7 @@ record_edge_info (basic_block bb)
if it never traverses the backedge to begin with. This
implies that any PHI nodes create equivalances that we
can attach to the loop exit edge. */
- int bool
+ bool alternative
= (EDGE_PRED (bb, 0)->flags & EDGE_DFS_BACK) ? 1 : 0;
gphi_iterator gsi;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-22 23:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 23:24 [committed] Fix comment typos noticed by Bernhard Jeff Law
2022-11-22 23:28 ` Andrew Pinski
2022-11-22 23:32 ` Jeff Law
2022-11-22 23:38 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).