* [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
@ 2023-06-20 9:45 Lehua Ding
2023-06-20 9:54 ` juzhe.zhong
2023-06-20 10:47 ` Robin Dapp
0 siblings, 2 replies; 10+ messages in thread
From: Lehua Ding @ 2023-06-20 9:45 UTC (permalink / raw)
To: gcc-patches
Cc: juzhe.zhong, rdapp.gcc, kito.cheng, palmer, jeffreyalaw, pan2.li
Hi,
This little patch fixes a compile warning issue that my previous patch introduced, sorry for introducing this issue.
Best,
Lehua
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_arg_has_vector): Add default branch.
---
gcc/config/riscv/riscv.cc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 6eb63a9d4de7..9558e28de3fc 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -3820,8 +3820,8 @@ riscv_arg_has_vector (const_tree type)
switch (TREE_CODE (type))
{
case RECORD_TYPE:
- /* If it is a record, it is further determined whether its fileds have
- vector type. */
+ /* If it is a record, it is further determined whether its fields have
+ vector type. */
for (tree f = TYPE_FIELDS (type); f; f = DECL_CHAIN (f))
if (TREE_CODE (f) == FIELD_DECL)
{
@@ -3835,6 +3835,8 @@ riscv_arg_has_vector (const_tree type)
break;
case ARRAY_TYPE:
return riscv_arg_has_vector (TREE_TYPE (type));
+ default:
+ break;
}
return false;
--
2.36.3
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 9:45 [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector Lehua Ding
@ 2023-06-20 9:54 ` juzhe.zhong
2023-06-20 10:47 ` Robin Dapp
1 sibling, 0 replies; 10+ messages in thread
From: juzhe.zhong @ 2023-06-20 9:54 UTC (permalink / raw)
To: 丁乐华, gcc-patches
Cc: Robin Dapp, kito.cheng, palmer, jeffreyalaw, pan2.li
[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]
Ok.
juzhe.zhong@rivai.ai
From: Lehua Ding
Date: 2023-06-20 17:45
To: gcc-patches
CC: juzhe.zhong; rdapp.gcc; kito.cheng; palmer; jeffreyalaw; pan2.li
Subject: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Hi,
This little patch fixes a compile warning issue that my previous patch introduced, sorry for introducing this issue.
Best,
Lehua
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_arg_has_vector): Add default branch.
---
gcc/config/riscv/riscv.cc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 6eb63a9d4de7..9558e28de3fc 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -3820,8 +3820,8 @@ riscv_arg_has_vector (const_tree type)
switch (TREE_CODE (type))
{
case RECORD_TYPE:
- /* If it is a record, it is further determined whether its fileds have
- vector type. */
+ /* If it is a record, it is further determined whether its fields have
+ vector type. */
for (tree f = TYPE_FIELDS (type); f; f = DECL_CHAIN (f))
if (TREE_CODE (f) == FIELD_DECL)
{
@@ -3835,6 +3835,8 @@ riscv_arg_has_vector (const_tree type)
break;
case ARRAY_TYPE:
return riscv_arg_has_vector (TREE_TYPE (type));
+ default:
+ break;
}
return false;
--
2.36.3
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 9:45 [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector Lehua Ding
2023-06-20 9:54 ` juzhe.zhong
@ 2023-06-20 10:47 ` Robin Dapp
2023-06-20 10:51 ` juzhe.zhong
1 sibling, 1 reply; 10+ messages in thread
From: Robin Dapp @ 2023-06-20 10:47 UTC (permalink / raw)
To: Lehua Ding, gcc-patches
Cc: rdapp.gcc, juzhe.zhong, kito.cheng, palmer, jeffreyalaw, pan2.li
> This little patch fixes a compile warning issue that my previous
> patch introduced, sorry for introducing this issue.
OK and obvious enough to push directly.
Regards
Robin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 10:47 ` Robin Dapp
@ 2023-06-20 10:51 ` juzhe.zhong
2023-06-20 10:56 ` Robin Dapp
2023-06-20 13:05 ` Robin Dapp
0 siblings, 2 replies; 10+ messages in thread
From: juzhe.zhong @ 2023-06-20 10:51 UTC (permalink / raw)
To: Robin Dapp, 丁乐华, gcc-patches
Cc: Robin Dapp, kito.cheng, palmer, jeffreyalaw, pan2.li
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Could you merge it ?
By the way, could Lehua get the write access?
Thanks.
juzhe.zhong@rivai.ai
From: Robin Dapp
Date: 2023-06-20 18:47
To: Lehua Ding; gcc-patches
CC: rdapp.gcc; juzhe.zhong; kito.cheng; palmer; jeffreyalaw; pan2.li
Subject: Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
> This little patch fixes a compile warning issue that my previous
> patch introduced, sorry for introducing this issue.
OK and obvious enough to push directly.
Regards
Robin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 10:51 ` juzhe.zhong
@ 2023-06-20 10:56 ` Robin Dapp
2023-06-20 13:11 ` Jeff Law
2023-06-20 13:05 ` Robin Dapp
1 sibling, 1 reply; 10+ messages in thread
From: Robin Dapp @ 2023-06-20 10:56 UTC (permalink / raw)
To: juzhe.zhong, 丁乐华, gcc-patches
Cc: rdapp.gcc, kito.cheng, palmer, jeffreyalaw, pan2.li
> Could you merge it ?
> By the way, could Lehua get the write access?
IMHO nothing stands in the way but I'll defer to Jeff to have
the "official seal" :)
Once he ACKs Lehua needs to go the usual way of requesting
sourceware access via https://sourceware.org/cgi-bin/pdw/ps_form.cgi.
Regards
Robin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 10:51 ` juzhe.zhong
2023-06-20 10:56 ` Robin Dapp
@ 2023-06-20 13:05 ` Robin Dapp
1 sibling, 0 replies; 10+ messages in thread
From: Robin Dapp @ 2023-06-20 13:05 UTC (permalink / raw)
To: juzhe.zhong, 丁乐华, gcc-patches
Cc: rdapp.gcc, kito.cheng, palmer, jeffreyalaw, pan2.li
> Could you merge it ?
Committed.
Regards
Robin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 10:56 ` Robin Dapp
@ 2023-06-20 13:11 ` Jeff Law
2023-06-20 13:22 ` Lehua Ding
2023-06-20 14:36 ` Mark Wielaard
0 siblings, 2 replies; 10+ messages in thread
From: Jeff Law @ 2023-06-20 13:11 UTC (permalink / raw)
To: Robin Dapp, juzhe.zhong, 丁乐华, gcc-patches
Cc: kito.cheng, palmer, pan2.li
On 6/20/23 04:56, Robin Dapp wrote:
>> Could you merge it ?
>> By the way, could Lehua get the write access?
>
> IMHO nothing stands in the way but I'll defer to Jeff to have
> the "official seal" :)
> Once he ACKs Lehua needs to go the usual way of requesting
> sourceware access via https://sourceware.org/cgi-bin/pdw/ps_form.cgi.
Lehua fills out that form. List me as the approver and the process will
run from there. Takes a day or two for everything to get into place.
jeff
ps. If Lehua has already filled out the form with Robin as the
approver, that's fine too. Might take a bit longer as I suspect the IT
folks may not recognize Robin.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 13:11 ` Jeff Law
@ 2023-06-20 13:22 ` Lehua Ding
2023-06-20 14:36 ` Mark Wielaard
1 sibling, 0 replies; 10+ messages in thread
From: Lehua Ding @ 2023-06-20 13:22 UTC (permalink / raw)
To: Jeff Law, Robin Dapp, 钟居哲, gcc-patches
Cc: kito.cheng, palmer, pan2.li
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
> Lehua fills out that form. List me as the approver and the process will
> run from there. Takes a day or two for everything to get into place.
I just followed this step to submit the form, thanks to Robin, Jeff and Juzhe.
Best,
Lehua
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 13:11 ` Jeff Law
2023-06-20 13:22 ` Lehua Ding
@ 2023-06-20 14:36 ` Mark Wielaard
2023-06-20 15:28 ` =?gb18030?B?TGVodWEgRGluZw==?=
1 sibling, 1 reply; 10+ messages in thread
From: Mark Wielaard @ 2023-06-20 14:36 UTC (permalink / raw)
To: Jeff Law, Robin Dapp, juzhe.zhong, 丁乐华, gcc-patches
Cc: kito.cheng, palmer, pan2.li
Hi all,
On Tue, 2023-06-20 at 07:11 -0600, Jeff Law wrote:
> On 6/20/23 04:56, Robin Dapp wrote:
> > > Could you merge it ?
> > > By the way, could Lehua get the write access?
> >
> > IMHO nothing stands in the way but I'll defer to Jeff to have
> > the "official seal" :)
> > Once he ACKs Lehua needs to go the usual way of requesting
> > sourceware access via https://sourceware.org/cgi-bin/pdw/ps_form.cgi.
> Lehua fills out that form. List me as the approver and the process will
> run from there. Takes a day or two for everything to get into place.
All done. Welcome Lehua.
> ps. If Lehua has already filled out the form with Robin as the > approver, that's fine too. Might take a bit longer as I suspect the
> IT folks may not recognize Robin.
Also Robin is right, you are on the hook as approver for the "official
seal" :) Because the "IT folks" check that the approver is listed as a
gcc maintainer and not just has write after approval status.
Cheers,
Mark
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
2023-06-20 14:36 ` Mark Wielaard
@ 2023-06-20 15:28 ` =?gb18030?B?TGVodWEgRGluZw==?=
0 siblings, 0 replies; 10+ messages in thread
From: =?gb18030?B?TGVodWEgRGluZw==?= @ 2023-06-20 15:28 UTC (permalink / raw)
To: =?gb18030?B?TWFyayBXaWVsYWFyZA==?=, =?gb18030?B?SmVmZiBMYXc=?=,
=?gb18030?B?Um9iaW4gRGFwcA==?=, =?gb18030?B?1tO+09Xc?=,
=?gb18030?B?Z2NjLXBhdGNoZXM=?=
Cc: =?gb18030?B?a2l0by5jaGVuZw==?=, =?gb18030?B?cGFsbWVy?=,
=?gb18030?B?cGFuMi5saQ==?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 121 bytes --]
> All done. Welcome Lehua.
I have received the system notification email, thank you very much.
Best,
Lehua
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-06-20 15:28 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-20 9:45 [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector Lehua Ding
2023-06-20 9:54 ` juzhe.zhong
2023-06-20 10:47 ` Robin Dapp
2023-06-20 10:51 ` juzhe.zhong
2023-06-20 10:56 ` Robin Dapp
2023-06-20 13:11 ` Jeff Law
2023-06-20 13:22 ` Lehua Ding
2023-06-20 14:36 ` Mark Wielaard
2023-06-20 15:28 ` =?gb18030?B?TGVodWEgRGluZw==?=
2023-06-20 13:05 ` Robin Dapp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).