From: Gerald Pfeifer <gerald@pfeifer.com>
To: Lulu Cheng <chenglulu@loongson.cn>
Cc: gcc-patches@gcc.gnu.org, xuchenghua@loongson.cn
Subject: Re: [PATCH][wwwdocs] gcc-13: Add loongarch '-mexplicit-relocs' support
Date: Tue, 26 Jul 2022 13:32:45 +0200 (CEST) [thread overview]
Message-ID: <cf188e3f-5251-6f0a-4959-fdc2193b1324@pfeifer.com> (raw)
In-Reply-To: <20220726072119.2910839-1-chenglulu@loongson.cn>
On Tue, 26 Jul 2022, Lulu Cheng wrote:
> +<h3 id="loongarch">LoongArch</h3>
> +<ul>
> + <li>The option <code>-mexplicit-relocs</code> has been added, this indicates
> + whether the <code>la.*</code> macro instructions will be generated when
> + loading symbolic addresses.
How about making this "...has been added. It indicates..." or, if you
prefer one sentence "...has been added to indicate whether"?
> + This feature requires binutils version 2.40 or later. If you want to use the
> + older version of bintuils, add compiler parameters
> + <code>-mno-explicit-relocs</code> at compile time.
"...older versions..." (or "...an older version...")
And I believe we can simplify and just say "...add <code>-mno-explicit..."
> + <li>The method for calling global functions changed from
> + <code>la.global + jirl</code> to <code>bl</code> when complied add
> + <code>-fplt</code>.
Do you mean "compiled" instead of "complied"?
And maybe "compiled with"?
> + <li>Enable option <code>-fsection-anchors</code> when <code>-O1</code> and
> + more advanced optimization.
How about "<code>-fsection-anchors</code> is now enabled with
<code>-O1</code> and above"?
If my suggestions make sense to you, please go ahead and commit with those
or variations thereof you may prefer.
If you have any questions, please let me know and we'll sort things out
quickly.
Thank you,
Gerald
next prev parent reply other threads:[~2022-07-26 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 7:21 Lulu Cheng
2022-07-26 9:44 ` Xi Ruoyao
2022-07-26 11:42 ` Lulu Cheng
2022-07-26 12:01 ` Xi Ruoyao
2022-07-26 13:26 ` Lulu Cheng
2022-07-26 14:15 ` [PATCH] LoongArch: adjust the default of -mexplicit-relocs by checking gas feature Xi Ruoyao
2022-07-27 1:34 ` Lulu Cheng
2022-07-27 2:22 ` Xi Ruoyao
2022-07-28 2:59 ` [PATCH][wwwdocs] gcc-13: Add loongarch '-mexplicit-relocs' support Lulu Cheng
2022-07-28 10:41 ` Xi Ruoyao
2022-07-28 13:06 ` Lulu Cheng
2022-07-26 11:32 ` Gerald Pfeifer [this message]
2022-07-26 12:28 ` Lulu Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf188e3f-5251-6f0a-4959-fdc2193b1324@pfeifer.com \
--to=gerald@pfeifer.com \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).