From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Eric Botcazou <botcazou@adacore.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
Peter Bergner <bergner@linux.ibm.com>,
Jeff Law <jlaw@ventanamicro.com>
Subject: Re: [PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]
Date: Wed, 9 Nov 2022 15:05:31 +0800 [thread overview]
Message-ID: <d47f3427-5184-7911-93d3-7acfb6b8da29@linux.ibm.com> (raw)
In-Reply-To: <13136293.uLZWGnKmhe@fomalhaut>
Hi Richi and Eric,
Thanks for your reviews and comments!
on 2022/11/8 18:37, Eric Botcazou wrote:
>> It looks reasonable - OK if the others CCed have no comments.
>
> My only comment is that it needs to be tested with languages enabling -fnon-
> call-exceptions by default (Ada & Go), if not already done.
>
The previous testings on powerpc64{,le}-linux-gnu covered language Go, but
not Ada. I re-tested it with languages c,c++,fortran,objc,obj-c++,go,ada
on powerpc64le-linux-gnu, the result looked good. Both x86 and aarch64
cfarm machines which I used for testing don't have gnat installed, do you
think testing Ada on ppc64le is enough?
BR,
Kewen
next prev parent reply other threads:[~2022-11-09 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 2:48 Kewen.Lin
2022-11-08 10:09 ` Richard Biener
2022-11-08 10:37 ` Eric Botcazou
2022-11-09 7:05 ` Kewen.Lin [this message]
2022-11-09 7:56 ` Eric Botcazou
2022-11-10 3:30 ` Kewen.Lin
2022-11-16 2:33 ` Kewen.Lin
2022-11-16 15:35 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d47f3427-5184-7911-93d3-7acfb6b8da29@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).