public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][DOCS] Document make jobserver related changes for GCC 13.
Date: Mon, 22 Aug 2022 11:24:26 +0200	[thread overview]
Message-ID: <d4a60d04-14c6-5450-e3cb-27094deacc8d@suse.cz> (raw)
In-Reply-To: <f75d5211-8d21-f4d1-a4cf-5860d0c9e77a@pfeifer.com>

On 8/18/22 22:53, Gerald Pfeifer wrote:
> On Thu, 18 Aug 2022, Martin Liška wrote:
>> Ready for master?
> 
> Nearly. :)
> 
>> +    Link-time optimization improvements:
>> +    <ul>
>> +        <li>LTO supports the newly added GNU make's jobserver that uses named pipes (<code>--jobserver-style=fifo</code>)
> 
> I believe that's just "GNU make" (instead of "GNU make's"), or maybe 
> "...the newly added jobserver of GNU make...".
> 
> Not 100% sure myself.
> 
>> +        <li>If make's jobserver is active, parallel LTO WPA streaming 
>>    communicates with it and so the streaming
>> +        does not lead to the system overcommitting.</li>
> 
> Might we be able to simplify this to something like
> 
>   "...parallel LTO WPA streaming communicates with it and thus avoids
>   system overcommitting" ?
> 
> 
> Just two minor points; the patch as such looks fine.

Thanks for the review, installed with your suggestions.

Martin

> 
> Thank you,
> Gerald


      reply	other threads:[~2022-08-22  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 11:33 Martin Liška
2022-08-18 20:53 ` Gerald Pfeifer
2022-08-22  9:24   ` Martin Liška [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4a60d04-14c6-5450-e3cb-27094deacc8d@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gerald@pfeifer.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).