From: Jeff Law <jeffreyalaw@gmail.com>
To: Martin Jambor <mjambor@suse.cz>, GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] sra: Disqualify bases of operands of asm gotos
Date: Sun, 21 Jan 2024 15:52:58 -0700 [thread overview]
Message-ID: <d84981e3-9353-4e07-afd2-8e4ff3063142@gmail.com> (raw)
In-Reply-To: <65a81ace.c80a0220.7bb5d.2f36SMTPIN_ADDED_BROKEN@mx.google.com>
On 1/17/24 11:21, Martin Jambor wrote:
> Hi,
>
> PR 110422 shows that SRA can ICE assuming there is a single edge
> outgoing from a block terminated with an asm goto. We need that for
> BB-terminating statements so that any adjustments they make to the
> aggregates can be copied over to their replacements. Because we can't
> have that after ASM gotos, we need to punt.
>
> Bootstrapped and tested on x86_64-linux, OK for master? It will need
> some tweaking for release branches, is it in principle OK for them too
> (after testing)?
>
> Thanks,
>
> Martin
>
>
> gcc/ChangeLog:
>
> 2024-01-17 Martin Jambor <mjambor@suse.cz>
>
> PR tree-optimization/110422
> * tree-sra.cc (scan_function): Disqualify bases of operands of asm
> gotos.
>
> gcc/testsuite/ChangeLog:
>
> 2024-01-17 Martin Jambor <mjambor@suse.cz>
>
> PR tree-optimization/110422
> * gcc.dg/torture/pr110422.c: New test.
OK. Also OK for the other release branches with necessary adjustments
after testing.
jeff
next parent reply other threads:[~2024-01-21 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <65a81ace.c80a0220.7bb5d.2f36SMTPIN_ADDED_BROKEN@mx.google.com>
2024-01-21 22:52 ` Jeff Law [this message]
2024-01-17 18:21 Martin Jambor
2024-01-18 7:14 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84981e3-9353-4e07-afd2-8e4ff3063142@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).