public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665.
@ 2023-09-06  9:57 Yang Yujie
  2023-09-06 11:00 ` Sam James
  2023-09-06 12:19 ` Richard Sandiford
  0 siblings, 2 replies; 4+ messages in thread
From: Yang Yujie @ 2023-09-06  9:57 UTC (permalink / raw)
  To: gcc-patches
  Cc: richard.sandiford, xry111, xuchenghua, panchenghui, chenglulu,
	Yang Yujie

gcc/ChangeLog:

	* config.gcc: remove non-POSIX syntax "<<<".
---
 gcc/config.gcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config.gcc b/gcc/config.gcc
index b2fe7c7ceef..6d4c8becd28 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -5189,7 +5189,7 @@ case "${target}" in
 				if test x${parse_state} = x"abi-base"; then
 					# Base ABI type
 					case ${component} in
-					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
+					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
 					*)
 						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
 						exit 1
-- 
2.36.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665.
  2023-09-06  9:57 [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665 Yang Yujie
@ 2023-09-06 11:00 ` Sam James
  2023-09-06 12:19 ` Richard Sandiford
  1 sibling, 0 replies; 4+ messages in thread
From: Sam James @ 2023-09-06 11:00 UTC (permalink / raw)
  To: Yang Yujie
  Cc: panchenghui, richard.sandiford, xuchenghua, chenglulu, gcc-patches


Yang Yujie <yangyujie@loongson.cn> writes:

> gcc/ChangeLog:
>
> 	* config.gcc: remove non-POSIX syntax "<<<".
> ---

Thanks, I was just about to report this.

>  gcc/config.gcc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index b2fe7c7ceef..6d4c8becd28 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -5189,7 +5189,7 @@ case "${target}" in
>  				if test x${parse_state} = x"abi-base"; then
>  					# Base ABI type
>  					case ${component} in
> -					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
> +					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
>  					*)
>  						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
>  						exit 1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665.
  2023-09-06  9:57 [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665 Yang Yujie
  2023-09-06 11:00 ` Sam James
@ 2023-09-06 12:19 ` Richard Sandiford
  2023-09-08  9:54   ` chenglulu
  1 sibling, 1 reply; 4+ messages in thread
From: Richard Sandiford @ 2023-09-06 12:19 UTC (permalink / raw)
  To: Yang Yujie; +Cc: gcc-patches, xry111, xuchenghua, panchenghui, chenglulu

Yang Yujie <yangyujie@loongson.cn> writes:
> gcc/ChangeLog:
>
> 	* config.gcc: remove non-POSIX syntax "<<<".

OK.  Thanks for the quick fix.

Richard.

> ---
>  gcc/config.gcc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index b2fe7c7ceef..6d4c8becd28 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -5189,7 +5189,7 @@ case "${target}" in
>  				if test x${parse_state} = x"abi-base"; then
>  					# Base ABI type
>  					case ${component} in
> -					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
> +					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
>  					*)
>  						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
>  						exit 1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re:[pushed] [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665.
  2023-09-06 12:19 ` Richard Sandiford
@ 2023-09-08  9:54   ` chenglulu
  0 siblings, 0 replies; 4+ messages in thread
From: chenglulu @ 2023-09-08  9:54 UTC (permalink / raw)
  To: Yang Yujie, gcc-patches, xry111, xuchenghua, panchenghui,
	richard.sandiford

Pushed to r14-3804.

在 2023/9/6 下午8:19, Richard Sandiford 写道:
> Yang Yujie <yangyujie@loongson.cn> writes:
>> gcc/ChangeLog:
>>
>> 	* config.gcc: remove non-POSIX syntax "<<<".
> OK.  Thanks for the quick fix.
>
> Richard.
>
>> ---
>>   gcc/config.gcc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>> index b2fe7c7ceef..6d4c8becd28 100644
>> --- a/gcc/config.gcc
>> +++ b/gcc/config.gcc
>> @@ -5189,7 +5189,7 @@ case "${target}" in
>>   				if test x${parse_state} = x"abi-base"; then
>>   					# Base ABI type
>>   					case ${component} in
>> -					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
>> +					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
>>   					*)
>>   						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
>>   						exit 1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-08  9:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06  9:57 [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665 Yang Yujie
2023-09-06 11:00 ` Sam James
2023-09-06 12:19 ` Richard Sandiford
2023-09-08  9:54   ` chenglulu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).