From: "Kewen.Lin" <linkw@linux.ibm.com>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, rs6000, v2] Additional cleanup of rs6000_builtin_mask
Date: Wed, 20 Jul 2022 09:23:20 +0800 [thread overview]
Message-ID: <ded03c62-d9ff-9e9b-89be-6e115a8d5989@linux.ibm.com> (raw)
In-Reply-To: <ff54dc9c90082626cfce8fe06c51fc2ed653515d.camel@vnet.ibm.com>
Hi Will,
on 2022/7/20 04:15, will schmidt wrote:
> [PATCH, rs6000, v2] Additional cleanup of rs6000_builtin_mask
>
> Hi,
> Post the rs6000 builtins rewrite, some of the leftover builtin
> code is redundant and can be removed.
> This replaces the usage of bu_mask in rs6000_target_modify_macros
> with checks against the rs6000_isa_flags equivalent directly. Thusly
> the bu_mask variable can be removed. After this update there
> are no other uses of rs6000_builtin_mask_calculate, so that function
> can also be safely removed.
>
> No functional change, though some output under debug has been removed.
>
> [V2]
> Per patch review and subsequent investigations, the
> rs6000_builtin_mask and x_rs6000_builtin_mask can also be removed, as
> well as the entirety of the rs6000_builtin_mask_names table.
>
I assumed this has been tested as before, so this patch is OK. Thanks!
> gcc/
> * config/rs6000/rs6000-c.cc: Update comments.
> (rs6000_target_modify_macros): Remove bu_mask references.
> (rs6000_define_or_undefine_macro): Replace bu_mask reference
> with a rs6000_cpu value check.
> (rs6000_cpu_cpp_builtins): Remove rs6000_builtin_mask_calculate()
> parameter from call to rs6000_target_modify_macros.
> * config/rs6000/rs6000-protos.h (rs6000_target_modify_macros,
> rs6000_target_modify_macros_ptr): Remove parameter from extern
> for the prototype.
> * config/rs6000/rs6000.cc (rs6000_target_modify_macros_ptr): Remove
> parameter from prototype, update calls to this function.
> (rs6000_print_builtin_options): Remove prototype, call and function.
> (rs6000_builtin_mask_calculate): Remove function.
> (rs6000_debug_reg_global): Remove call to rs6000_print_builtin_options.
> (rs6000_option_override_internal): Remove rs6000_builtin_mask var
> and builtin_mask debug output.
> (rs6000_builtin_mask_names): Remove.
> (rs6000_pragma_target_parse): Remove prev_bumask, cur_bumask,
> diff_bumask references; Update calls to
> rs6000_target_modify_ptr.
Nit: this "rs6000_target_modify_ptr" seems not necessarily to start one new
line. :)
BR,
Kewen
> * config/rs6000/rs6000.opt (rs6000_builtin_mask): Remove.
>
prev parent reply other threads:[~2022-07-20 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 21:39 [PATCH, rs6000] " will schmidt
2022-07-14 3:28 ` Kewen.Lin
2022-07-15 21:22 ` will schmidt
2022-07-19 20:15 ` [PATCH, rs6000, v2] " will schmidt
2022-07-20 1:23 ` Kewen.Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded03c62-d9ff-9e9b-89be-6e115a8d5989@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).