From: Tom Honermann <tom@honermann.net>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/3 v3] testsuite: Add tests for C2X N2653 char8_t and UTF-8 string literal changes
Date: Tue, 2 Aug 2022 14:02:45 -0400 [thread overview]
Message-ID: <dee6ff9a-f13c-fa6a-1a9f-b1d4de17d91f@honermann.net> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2208021652220.861046@digraph.polyomino.org.uk>
On 8/2/22 12:53 PM, Joseph Myers wrote:
> On Mon, 1 Aug 2022, Tom Honermann via Gcc-patches wrote:
>
>> This change provides new tests for the core language and compiler
>> dependent library changes adopted for C2X via WG14 N2653.
> Could you please send a complete patch series? I'm not sure what the
> matching patches 1 and 3 are. Also, I don't generally find it helpful for
> tests to be separated from the patch making the changes they test, since
> tests are necessary to review of that code.
Absolutely. I'll merge the implementation and test commits, so the next
series (v4) will have just two commits; one for the C2X N2653
implementation and the other for the C++ u8 preprocessor string type
fix. Coming right up.
Tom.
next prev parent reply other threads:[~2022-08-02 18:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 17:59 [PATCH 0/3] Implement C2X N2653 (char8_t) and correct UTF-8 character literal type in preprocessor directives for C++ Tom Honermann
2022-07-25 17:59 ` [PATCH 1/3] C: Implement C2X N2653 char8_t and UTF-8 string literal changes Tom Honermann
2022-07-27 23:20 ` Joseph Myers
2022-07-30 23:17 ` Tom Honermann
2022-08-01 18:32 ` [PATCH 1/3 v2] " Tom Honermann
2022-07-25 17:59 ` [PATCH 2/3] testsuite: Add tests for " Tom Honermann
2022-07-27 23:23 ` Joseph Myers
2022-07-31 21:47 ` Tom Honermann
2022-08-01 18:34 ` [PATCH 2/3 v2] " Tom Honermann
2022-08-01 19:13 ` Joseph Myers
2022-08-01 22:36 ` Tom Honermann
2022-08-01 22:39 ` [PATCH 2/3 v3] " Tom Honermann
2022-08-02 16:53 ` Joseph Myers
2022-08-02 18:02 ` Tom Honermann [this message]
2022-07-25 17:59 ` [PATCH 3/3] c++/106426: Treat u8 character literals as unsigned in char8_t modes Tom Honermann
2022-07-25 18:05 ` Andrew Pinski
2022-07-26 1:32 ` [PATCH 3/3 v2] preprocessor/106426: " Tom Honermann
2022-07-26 1:38 ` [PATCH 3/3] c++/106426: " Tom Honermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee6ff9a-f13c-fa6a-1a9f-b1d4de17d91f@honermann.net \
--to=tom@honermann.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).