From: Jeff Law <jeffreyalaw@gmail.com>
To: Eugene Rozenfeld <Eugene.Rozenfeld@microsoft.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix count comparison in ipa-cp
Date: Tue, 22 Nov 2022 13:02:47 -0700 [thread overview]
Message-ID: <e67ff611-bc23-b173-6378-8a37f7edf092@gmail.com> (raw)
In-Reply-To: <CY5PR21MB35427E6C2EE445568BFA6BA4910A9@CY5PR21MB3542.namprd21.prod.outlook.com>
On 11/21/22 14:26, Eugene Rozenfeld via Gcc-patches wrote:
> The existing comparison was incorrect for non-PRECISE counts
> (e.g., AFDO): we could end up with a 0 base_count, which could
> lead to asserts, e.g., in good_cloning_opportunity_p.
>
> gcc/ChangeLog:
>
> * ipa-cp.cc (ipcp_propagate_stage): Fix profile count comparison.
OK. Probably somewhat painful to pull together a reliable test for
this, right?
Jeff
next prev parent reply other threads:[~2022-11-22 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 21:26 Eugene Rozenfeld
2022-11-22 20:02 ` Jeff Law [this message]
2022-12-07 1:25 ` [EXTERNAL] " Eugene Rozenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67ff611-bc23-b173-6378-8a37f7edf092@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=Eugene.Rozenfeld@microsoft.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).