From: David Malcolm <dmalcolm@redhat.com>
To: Lewis Hyatt <lhyatt@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] diagnostics: Make line-ending logic consistent with libcpp [PR91733]
Date: Fri, 08 Jul 2022 09:41:50 -0400 [thread overview]
Message-ID: <e7b5f70aa857f0d12f96890b7195b87447366a83.camel@redhat.com> (raw)
In-Reply-To: <20220708015614.GA90703@ldh-imac.local>
On Thu, 2022-07-07 at 21:56 -0400, Lewis Hyatt wrote:
> Hello-
>
> The PR (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91733) points
> out that,
> while libcpp recognizes a lone '\r' as a valid line-ending character,
> the
> infrastructure that obtains source lines to be printed in diagnostics
> does
> not, and hence diagnostics do not output the intended portion of a
> source
> file that uses such line endings. The PR's author suggests that
> libcpp
> should stop accepting '\r' line endings, but that seems rather
> controversial
> and not likely to change. Fixing the diagnostics is easy enough
> though, and
> that's done by the attached patch. Please let me know if it looks OK,
> thanks! bootstrap + regtest all languages looks good, with just new
> PASSes
> for the new testcase.
>
> FAIL 103 103
> PASS 543592 543627
> UNSUPPORTED 15298 15298
> UNTESTED 136 136
> XFAIL 4130 4130
> XPASS 20 20
>
The patch looks good to me.
Thanks
Dave
prev parent reply other threads:[~2022-07-08 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 1:56 Lewis Hyatt
2022-07-08 13:41 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7b5f70aa857f0d12f96890b7195b87447366a83.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lhyatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).