From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>, GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Convert flag_finite_math_only uses in frange to HONOR_*.
Date: Thu, 27 Oct 2022 16:59:43 -0600 [thread overview]
Message-ID: <e8919ad5-81a4-c0f3-c89a-ce0fec218fe6@gmail.com> (raw)
In-Reply-To: <20221025205901.125058-1-aldyh@redhat.com>
On 10/25/22 14:59, Aldy Hernandez via Gcc-patches wrote:
> [As Richi, and probably Jakub, have mentioned in the past...]
>
> As mentioned earlier, we should be using HONOR_* on types rather than
> flag_finite_math_only.
>
> Will commit pending tests.
>
> gcc/ChangeLog:
>
> * value-range.cc (frange::set): Use HONOR_*.
> (frange::verify_range): Same.
> * value-range.h (frange_val_min): Same.
> (frange_val_max): Same.
I haven't verified it's this patch, but our friend the vax regression is
back:
cc1: internal compiler error: in fail, at selftest.cc:47
0x1686807 selftest::fail(selftest::location const&, char const*)
../../../gcc/gcc/selftest.cc:47
0x10578d2 range_tests_floats
../../../gcc/gcc/value-range.cc:4038
0x10658fd range_tests_floats_various
../../../gcc/gcc/value-range.cc:4056
0x10658fd selftest::range_tests()
../../../gcc/gcc/value-range.cc:4069
http://law-sandy.freeddns.org:8080/job/vax-unknown-linux/1458/console
Jeff
next prev parent reply other threads:[~2022-10-27 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 20:59 Aldy Hernandez
2022-10-27 22:59 ` Jeff Law [this message]
2022-10-28 6:22 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8919ad5-81a4-c0f3-c89a-ce0fec218fe6@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).