Re: [PATCH] Convert flag_finite_math_only uses in frange to HONOR_*.

[Aldy Hernandez <aldyh@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

On Fri, Oct 28, 2022 at 1:00 AM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
> On 10/25/22 14:59, Aldy Hernandez via Gcc-patches wrote:
> > [As Richi, and probably Jakub, have mentioned in the past...]
> >
> > As mentioned earlier, we should be using HONOR_* on types rather than
> > flag_finite_math_only.
> >
> > Will commit pending tests.
> >
> > gcc/ChangeLog:
> >
> >       * value-range.cc (frange::set): Use HONOR_*.
> >       (frange::verify_range): Same.
> >       * value-range.h (frange_val_min): Same.
> >       (frange_val_max): Same.
>
> I haven't verified it's this patch, but our friend the vax regression is
> back:

Bah.  I suck.  There was one remaining use of flag_finite_math_only in
the self tests.  Fixed and finally done:

$ grep flag_finite *range*
value-range.cc:  int save_finite_math_only = flag_finite_math_only;
value-range.cc:  flag_finite_math_only = 1;
value-range.cc:  flag_finite_math_only = 0;
value-range.cc:  flag_finite_math_only = save_finite_math_only;

Aldy

[-- Attachment #2: 0001-Change-remaining-flag_finite_math_only-use-in-value-.patch --]
[-- Type: text/x-patch, Size: 824 bytes --]

From dc55841d9a45a2d93eaedd68841f7514723939d1 Mon Sep 17 00:00:00 2001
From: Aldy Hernandez <aldyh@redhat.com>
Date: Fri, 28 Oct 2022 08:13:38 +0200
Subject: [PATCH] Change remaining flag_finite_math_only use in value-range.cc.

gcc/ChangeLog:

	* value-range.cc (range_tests_floats): Use HONOR_INFINITIES.
---
 gcc/value-range.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index 77e5a2cc299..03b3c4b4a65 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -4031,7 +4031,7 @@ range_tests_floats ()
   r0.intersect (r1);
   ASSERT_TRUE (r0.undefined_p ());
 
-  if (!flag_finite_math_only)
+  if (HONOR_INFINITIES (float_type_node))
     {
       // Make sure [-Inf, -Inf] doesn't get normalized.
       r0 = frange_float ("-Inf", "-Inf");
-- 
2.37.3