From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Cc: richard.earnshaw@arm.com
Subject: Re: [PATCH 3/9] arm: Don't add crtfastmath.o for -shared
Date: Fri, 13 Jan 2023 10:53:45 +0000 [thread overview]
Message-ID: <e8fa4062-5715-0985-5af3-eafd34219c3f@foss.arm.com> (raw)
In-Reply-To: <20230113080015.6E41613913@imap2.suse-dmz.suse.de>
On 13/01/2023 08:00, Richard Biener via Gcc-patches wrote:
> Don't add crtfastmath.o for -shared to avoid altering the FP
> environment when loading a shared library.
>
> PR target/55522
> * config/arm/linux-eabi.h (ENDFILE_SPEC): Don't add
> crtfastmath.o for -shared.
> * config/arm/unknown-elf.h (STARTFILE_SPEC): Likewise.
OK.
R.
> ---
> gcc/config/arm/linux-eabi.h | 2 +-
> gcc/config/arm/unknown-elf.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/arm/linux-eabi.h b/gcc/config/arm/linux-eabi.h
> index 57f830f0176..a119875599d 100644
> --- a/gcc/config/arm/linux-eabi.h
> +++ b/gcc/config/arm/linux-eabi.h
> @@ -121,7 +121,7 @@
>
> #undef ENDFILE_SPEC
> #define ENDFILE_SPEC \
> - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s} " \
> + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}} " \
> LINUX_OR_ANDROID_LD (GNU_USER_TARGET_ENDFILE_SPEC, ANDROID_ENDFILE_SPEC)
>
> /* Use the default LIBGCC_SPEC, not the version in linux-elf.h, as we
> diff --git a/gcc/config/arm/unknown-elf.h b/gcc/config/arm/unknown-elf.h
> index 464d38b6cc6..397ac3f68b9 100644
> --- a/gcc/config/arm/unknown-elf.h
> +++ b/gcc/config/arm/unknown-elf.h
> @@ -33,7 +33,7 @@
>
> #undef STARTFILE_SPEC
> #define STARTFILE_SPEC \
> - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s} " \
> + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}} " \
> UNKNOWN_ELF_STARTFILE_SPEC
>
> #define UNKNOWN_ELF_ENDFILE_SPEC "crtend%O%s crtn%O%s"
prev parent reply other threads:[~2023-01-13 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 8:00 Richard Biener
2023-01-13 10:53 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8fa4062-5715-0985-5af3-eafd34219c3f@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).