public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>, juzhe.zhong@rivai.ai
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, palmer@dabbelt.com
Subject: Re: [PATCH 1/3] RISC-V: Add auto-vectorization compile option for RVV
Date: Tue, 25 Apr 2023 21:00:22 -0600	[thread overview]
Message-ID: <e98b49f7-45a7-3678-c900-34e4965f4514@gmail.com> (raw)
In-Reply-To: <CAFiYyc3equoGBuRwivfLCPwHaiu4oqzm-LQojvXdJj7CPUW0Ww@mail.gmail.com>



On 4/20/23 05:08, Richard Biener wrote:
> On Wed, Apr 19, 2023 at 6:38 PM <juzhe.zhong@rivai.ai> wrote:
>>
>> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>>
>> This patch is adding 2 compile option for RVV auto-vectorization.
>> 1. -param=riscv-autovec-preference=
>>     This option is to specify the auto-vectorization approach for RVV.
>>     Currently, we only support scalable and fixed-vlmax.
>>
>>      - scalable means VLA auto-vectorization. The vector-length to compiler is
>>        unknown and runtime invariant. Such approach can allow us compile the code
>>        run on any vector-length RVV CPU.
>>
>>      - fixed-vlmax means the compile known the RVV CPU vector-length, compile option
>>        in fixed-length VLS auto-vectorization. Meaning if we specify vector-length=512.
>>        The execution file can only run on vector-length = 512 RVV CPU.
>>
>>      - TODO: we may need to support min-length VLS auto-vectorization, means the execution
>>        file can run on larger length RVV CPU.
> 
> Just as a generic comment - if the option should be exposed to users
> rather than just used
> for testsuite or development purposes it should eventually become a
> -mautovec-preference=
> flag (no need to prefix with riscv).
I would expect that we don't want users twiddling the autovectorization 
style in the long term.  I do support having the param so that we can 
can do A/B experiments across the styles to identify gaps.

jeff

  reply	other threads:[~2023-04-26  3:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 16:36 [PATCH 0/3] RISC-V: Basic enable RVV auto-vectorizaiton juzhe.zhong
2023-04-19 16:36 ` [PATCH 1/3] RISC-V: Add auto-vectorization compile option for RVV juzhe.zhong
2023-04-20 11:08   ` Richard Biener
2023-04-26  3:00     ` Jeff Law [this message]
2023-04-19 16:36 ` [PATCH 2/3] RISC-V: Enable basic auto-vectorization " juzhe.zhong
2023-04-19 16:36 ` [PATCH 3/3] RISC-V: Add sanity testcases for RVV auto-vectorization juzhe.zhong
2023-04-19 16:45 ` [PATCH 0/3] RISC-V: Basic enable RVV auto-vectorizaiton 钟居哲
  -- strict thread matches above, loose matches on Subject: below --
2023-04-19 16:36 juzhe.zhong
2023-04-19 16:36 ` [PATCH 1/3] RISC-V: Add auto-vectorization compile option for RVV juzhe.zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e98b49f7-45a7-3678-c900-34e4965f4514@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).