From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Surya Kumari Jangala <jskumari@linux.vnet.ibm.com>
Cc: Peter Bergner <bergner@linux.ibm.com>,
gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] testsuite: Fix failure in test pr105586.c [PR107171]
Date: Wed, 26 Oct 2022 10:47:13 +0800 [thread overview]
Message-ID: <e9eab09a-1cbe-b564-155e-1412edd20c63@linux.ibm.com> (raw)
In-Reply-To: <8723e38f-f7ee-aac7-7b8d-3dce61038a9f@linux.vnet.ibm.com>
Hi Surya,
on 2022/10/14 01:02, Surya Kumari Jangala via Gcc-patches wrote:
> testsuite: Fix failure in test pr105586.c [PR107171]
>
> The test pr105586.c fails on a big endian system when run in 32bit
> mode. The failure occurs as the test case does not guard against
> unsupported __int128.
>
I thought this is taken as an obvious fix and it didn't ask for a
review/approval, but I just noticed it's not committed yet, so I
assumed maybe you meant to ask for an approval?
Then this patch is OK, it's even obvious, thanks!
BR,
Kewen
> 2022-10-13 Surya Kumari Jangala <jskumari@linux.ibm.com>
>
> gcc/testsuite/
> PR testsuite/107171
> * gcc.target/powerpc/pr105586.c: Guard against unsupported
> __int128.
>
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr105586.c b/gcc/testsuite/gcc.target/powerpc/pr105586.c
> index bd397f5..3f88a09 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr105586.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr105586.c
> @@ -1,4 +1,5 @@
> /* { dg-options "-mdejagnu-tune=power4 -O2 -fcompare-debug -fno-if-conversion -fno-guess-branch-probability" } */
> +/* { dg-require-effective-target int128 } */
>
> extern int bar(int i);
prev parent reply other threads:[~2022-10-26 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 17:02 Surya Kumari Jangala
2022-10-26 2:47 ` Kewen.Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9eab09a-1cbe-b564-155e-1412edd20c63@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jskumari@linux.vnet.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).