From: Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH 5/5] xtensa: Eliminate [DS]Cmode hard register clobber that is immediately followed by whole overwrite the register
Date: Tue, 14 Jun 2022 12:53:04 +0900 [thread overview]
Message-ID: <eab26d15-8cd0-16cb-e786-afe7ee501aa5@yahoo.co.jp> (raw)
RTL expansion of substitution to [DS]Cmode hard register includes obstructive
register clobber.
A simplest example:
double _Complex test(double _Complex c) {
return c;
}
will be converted to:
(set (reg:DF 42 [ c ]) (reg:DF 2 a2))
(set (reg:DF 43 [ c+8 ]) (reg:DF 4 a4))
(clobber (reg:DC 2 a2))
(set (reg:DF 2 a2) (reg:DF 42 [ c ]))
(set (reg:DF 4 a4) (reg:DF 43 [ c+8 ]))
(use (reg:DC 2 a2))
(return)
and then finally:
test:
mov a8, a2
mov a9, a3
mov a6, a4
mov a7, a5
mov a2, a8
mov a3, a9
mov a4, a6
mov a5, a7
ret
As you see, it is so ridiculous.
This patch eliminates such clobber in order to prune away the wasted move
instructions by the optimizer:
test:
ret
gcc/ChangeLog:
* config/xtensa/xtensa.md (DSC): New split pattern and mode iterator.
---
gcc/config/xtensa/xtensa.md | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md
index e6f5594762f..3b3be5f8436 100644
--- a/gcc/config/xtensa/xtensa.md
+++ b/gcc/config/xtensa/xtensa.md
@@ -86,6 +86,10 @@
;; This code iterator is for *shlrd and its variants.
(define_code_iterator ior_op [ior plus])
+;; This mode iterator allows the DC and SC patterns to be defined from
+;; the same template.
+(define_mode_iterator DSC [DC SC])
+
\f
;; Attributes.
@@ -2755,3 +2759,27 @@
operands[6] = gen_rtx_MEM (SFmode, XEXP (operands[6], 0));
operands[7] = gen_rtx_MEM (SFmode, XEXP (operands[7], 0));
})
+
+(define_split
+ [(clobber (match_operand:DSC 0 "register_operand"))]
+ "GP_REG_P (REGNO (operands[0]))"
+ [(const_int 0)]
+{
+ unsigned int regno = REGNO (operands[0]);
+ machine_mode inner_mode = GET_MODE_INNER (<MODE>mode);
+ rtx_insn *insn;
+ rtx x;
+ if (! ((insn = next_nonnote_nondebug_insn (curr_insn))
+ && NONJUMP_INSN_P (insn)
+ && GET_CODE (x = PATTERN (insn)) == SET
+ && REG_P (x = XEXP (x, 0))
+ && GET_MODE (x) == inner_mode
+ && REGNO (x) == regno
+ && (insn = next_nonnote_nondebug_insn (insn))
+ && NONJUMP_INSN_P (insn)
+ && GET_CODE (x = PATTERN (insn)) == SET
+ && REG_P (x = XEXP (x, 0))
+ && GET_MODE (x) == inner_mode
+ && REGNO (x) == regno + REG_NREGS (operands[0]) / 2))
+ FAIL;
+})
--
2.20.1
next reply other threads:[~2022-06-14 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 3:53 Takayuki 'January June' Suwa [this message]
2022-06-16 0:02 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eab26d15-8cd0-16cb-e786-afe7ee501aa5@yahoo.co.jp \
--to=jjsuwa_sys3175@yahoo.co.jp \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).