* [PATCH] diagnostics: Delete config pointer before overwriting it.
@ 2023-09-01 19:16 Mikael Morin
2023-09-01 23:54 ` David Malcolm
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Morin @ 2023-09-01 19:16 UTC (permalink / raw)
To: gcc-patches
Hello,
this is a fix for a small memory leak in the fortran frontend.
Tested on x86_64-pc-linux-gnu, nothing stands out besides the
apparently well-known guality instability.
OK for master ?
-- >8 --
Delete m_client_data_hooks before it is reassigned in
tree_diagnostics_defaults. This fixes a small memory leak in the fortran
frontend, which restores the diagnostics configurations to their default
values with a call to tree_diagnostics_defaults at the end of the main parse
hook.
gcc/ChangeLog:
* tree-diagnostic.cc (tree_diagnostics_defaults): Delete allocated
pointer before overwriting it.
---
gcc/tree-diagnostic.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/tree-diagnostic.cc b/gcc/tree-diagnostic.cc
index 731e3559cd8..d2f6637b6d9 100644
--- a/gcc/tree-diagnostic.cc
+++ b/gcc/tree-diagnostic.cc
@@ -377,5 +377,6 @@ tree_diagnostics_defaults (diagnostic_context *context)
context->print_path = default_tree_diagnostic_path_printer;
context->make_json_for_path = default_tree_make_json_for_path;
context->set_locations_cb = set_inlining_locations;
+ delete context->m_client_data_hooks;
context->m_client_data_hooks = make_compiler_data_hooks ();
}
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] diagnostics: Delete config pointer before overwriting it.
2023-09-01 19:16 [PATCH] diagnostics: Delete config pointer before overwriting it Mikael Morin
@ 2023-09-01 23:54 ` David Malcolm
0 siblings, 0 replies; 2+ messages in thread
From: David Malcolm @ 2023-09-01 23:54 UTC (permalink / raw)
To: Mikael Morin, gcc-patches
On Fri, 2023-09-01 at 21:16 +0200, Mikael Morin via Gcc-patches wrote:
> Hello,
>
> this is a fix for a small memory leak in the fortran frontend.
> Tested on x86_64-pc-linux-gnu, nothing stands out besides the
> apparently well-known guality instability.
> OK for master ?
LGTM, thanks!
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-01 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01 19:16 [PATCH] diagnostics: Delete config pointer before overwriting it Mikael Morin
2023-09-01 23:54 ` David Malcolm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).