From: David Malcolm <dmalcolm@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] diagnostics: Fix selftest ICE in certain locales [PR107722]
Date: Wed, 23 Nov 2022 08:20:01 -0500 [thread overview]
Message-ID: <ec3f59200ac958afdc1681f3b34bc90028968b12.camel@redhat.com> (raw)
In-Reply-To: <Y33fGGNXV6JNCK1p@tucnak>
On Wed, 2022-11-23 at 09:51 +0100, Jakub Jelinek wrote:
> Hi!
>
> As reported in the PR, since special_fname_builtin () call has been
> introduced, the diagnostics code compares filename against _("<built-
> in>")
> rather than "<built-in>", which means that if self tests are
> performed
> with the string being translated, one self-test fails.
> The following patch fixes that.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux (with normal C
> locale)
> and by the reporter in German, where it fixes the problem. Ok for
> trunk?
OK
Thanks
Dave
prev parent reply other threads:[~2022-11-23 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 8:51 Jakub Jelinek
2022-11-23 13:20 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3f59200ac958afdc1681f3b34bc90028968b12.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).