From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: PING^2 : Re: [PATCH 03/10] expr.cc: use final/override on op_by_pieces_d vfuncs
Date: Fri, 24 Jun 2022 14:12:50 -0400 [thread overview]
Message-ID: <ed801f084ded909c2143ebb9c0b45e66a449c8bc.camel@redhat.com> (raw)
In-Reply-To: <55c38eed09f7896673e3c6ba8bd6d63405174c6d.camel@redhat.com>
On Mon, 2022-06-13 at 14:25 -0400, David Malcolm wrote:
> Ping on this patch:
> https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595434.html
>
> OK for trunk?
>
> Thanks
> Dave
>
> On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote:
> > gcc/ChangeLog:
> > * expr.cc: Add "final" and "override" to op_by_pieces_d
> > vfunc
> > implementations as appropriate.
> >
> > Signed-off-by: David Malcolm <dmalcolm@redhat.com>
> > ---
> > gcc/expr.cc | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/gcc/expr.cc b/gcc/expr.cc
> > index 7197996cec7..ce58728862a 100644
> > --- a/gcc/expr.cc
> > +++ b/gcc/expr.cc
> > @@ -1357,8 +1357,8 @@ op_by_pieces_d::run ()
> > class move_by_pieces_d : public op_by_pieces_d
> > {
> > insn_gen_fn m_gen_fun;
> > - void generate (rtx, rtx, machine_mode);
> > - bool prepare_mode (machine_mode, unsigned int);
> > + void generate (rtx, rtx, machine_mode) final override;
> > + bool prepare_mode (machine_mode, unsigned int) final override;
> >
> > public:
> > move_by_pieces_d (rtx to, rtx from, unsigned HOST_WIDE_INT len,
> > @@ -1453,8 +1453,8 @@ move_by_pieces (rtx to, rtx from, unsigned
> > HOST_WIDE_INT len,
> > class store_by_pieces_d : public op_by_pieces_d
> > {
> > insn_gen_fn m_gen_fun;
> > - void generate (rtx, rtx, machine_mode);
> > - bool prepare_mode (machine_mode, unsigned int);
> > + void generate (rtx, rtx, machine_mode) final override;
> > + bool prepare_mode (machine_mode, unsigned int) final override;
> >
> > public:
> > store_by_pieces_d (rtx to, by_pieces_constfn cfn, void
> > *cfn_data,
> > @@ -1650,9 +1650,9 @@ class compare_by_pieces_d : public
> > op_by_pieces_d
> > rtx m_accumulator;
> > int m_count, m_batch;
> >
> > - void generate (rtx, rtx, machine_mode);
> > - bool prepare_mode (machine_mode, unsigned int);
> > - void finish_mode (machine_mode);
> > + void generate (rtx, rtx, machine_mode) final override;
> > + bool prepare_mode (machine_mode, unsigned int) final override;
> > + void finish_mode (machine_mode) final override;
> > public:
> > compare_by_pieces_d (rtx op0, rtx op1, by_pieces_constfn
> > op1_cfn,
> > void *op1_cfn_data, HOST_WIDE_INT len, int
> > align,
>
next prev parent reply other threads:[~2022-06-24 18:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 19:28 [PATCH 00/10] Add 'final' and 'override' where missing David Malcolm
2022-05-23 19:28 ` [PATCH 01/10] Add 'final' and 'override' to opt_pass vfunc impls David Malcolm
2022-06-13 18:22 ` PING: " David Malcolm
2022-06-24 18:08 ` PING^2: " David Malcolm
2022-06-24 18:45 ` Jeff Law
2022-06-27 21:16 ` David Malcolm
2022-05-23 19:28 ` [PATCH 02/10] Add 'final' and 'override' on dom_walker " David Malcolm
2022-06-13 18:23 ` PING " David Malcolm
2022-06-24 18:10 ` PING^2 " David Malcolm
2022-05-23 19:28 ` [PATCH 03/10] expr.cc: use final/override on op_by_pieces_d vfuncs David Malcolm
2022-06-13 18:25 ` PING: " David Malcolm
2022-06-24 18:12 ` David Malcolm [this message]
2022-05-23 19:28 ` [PATCH 04/10] tree-switch-conversion.h: use final/override for cluster vfunc impls David Malcolm
2022-06-13 18:26 ` PING " David Malcolm
2022-06-24 18:14 ` PING^2 : " David Malcolm
2022-05-23 19:28 ` [PATCH 05/10] d: add 'final' and 'override' to gcc/d/*.cc 'visit' impls David Malcolm
2022-05-24 12:56 ` Iain Buclaw
2022-05-24 13:15 ` David Malcolm
2022-05-24 15:11 ` Iain Buclaw
2022-05-23 19:28 ` [PATCH 06/10] ipa: add 'final' and 'override' to call_summary_base vfunc impls David Malcolm
2022-05-24 7:36 ` Martin Liška
2022-05-23 19:28 ` [PATCH 07/10] value-relation.h: add 'final' and 'override' to relation_oracle " David Malcolm
2022-06-13 18:28 ` PING " David Malcolm
2022-06-14 0:45 ` Aldy Hernandez
2022-06-14 1:24 ` David Malcolm
2022-06-15 13:33 ` Andrew MacLeod
2022-06-15 21:58 ` David Malcolm
2022-05-23 19:28 ` [PATCH 08/10] i386: add 'final' and 'override' to scalar_chain " David Malcolm
2022-06-13 18:30 ` PING: " David Malcolm
2022-06-24 18:19 ` PING^2 : " David Malcolm
2022-06-24 20:58 ` Uros Bizjak
2022-06-27 21:25 ` David Malcolm
2022-08-16 8:55 ` [PATCH][pushed] i386: add 'final' and 'override' to scalar_chain Martin Liška
2022-05-23 19:28 ` [PATCH 09/10] tree-vect-slp-patterns.cc: add 'final' and 'override' to vect_pattern::build impls David Malcolm
2022-05-24 6:44 ` Richard Biener
2022-05-23 19:28 ` [PATCH 10/10] Add 'final' and 'override' in various places David Malcolm
2022-06-13 18:30 ` PING " David Malcolm
2022-06-24 18:20 ` PING^2: " David Malcolm
2022-05-25 3:29 ` [PATCH 00/10] Add 'final' and 'override' where missing Eric Gallager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed801f084ded909c2143ebb9c0b45e66a449c8bc.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).