From: Jeff Law <jeffreyalaw@gmail.com>
To: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "jakub@redhat.com" <jakub@redhat.com>, Andrew Pinski <pinskia@gmail.com>
Subject: Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610]
Date: Mon, 17 Jul 2023 08:27:17 -0600 [thread overview]
Message-ID: <ef6f1f55-1677-c004-a39e-d1116317458a@gmail.com> (raw)
In-Reply-To: <3eb8505a-5fda-3f03-9463-70e045c75ceb@arm.com>
On 7/17/23 05:55, Andre Vieira (lists) wrote:
>
>
> On 11/07/2023 23:28, Jeff Law wrote:
>>
>>
>> On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote:
>>> Hi,
>>>
>>> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H
>>> list, as insn-opinit.h is now required by internal-fn.h. This will
>>> lead to insn-opinit.h, among the other OPTABS_H header files, being
>>> installed in the plugin directory.
>>>
>>> Bootstrapped aarch64-unknown-linux-gnu.
>>>
>>> @Jakub: could you check to see if it also addresses PR 110284?
>>>
>>>
>>> gcc/ChangeLog:
>>>
>>> PR 110610
>>> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
>> Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h
>> and insn-codes.h and neither of those #include other headers do they?
>>
>>
>
> Yeah, there was no particular reason other than I just felt the Makefile
> structure sort of lend itself that way. I checked genopinit.cc and it
> seems insn-opinit.h doesn't include any other header files, only the
> sources do, so I've changed the patch to only add insn-opinit.h to
> INTERNAL_FN_H.
>
> -------------------
>
> This patch fixes PR110610 by including insn-opinit.h in the
> INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h.
> This will lead to insn-opinit.h, among the other OPTABS_H header files,
> being installed in the plugin directory.
>
> Bootstrapped aarch64-unknown-linux-gnu.
>
> gcc/ChangeLog:
> PR 110610
> * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h.
OK
jeff
prev parent reply other threads:[~2023-07-17 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 10:37 Andre Vieira (lists)
2023-07-11 22:28 ` Jeff Law
2023-07-17 11:55 ` Andre Vieira (lists)
2023-07-17 14:27 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef6f1f55-1677-c004-a39e-d1116317458a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andre.simoesdiasvieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).