From: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
To: Jeff Law <jeffreyalaw@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "jakub@redhat.com" <jakub@redhat.com>, Andrew Pinski <pinskia@gmail.com>
Subject: Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610]
Date: Mon, 17 Jul 2023 12:55:35 +0100 [thread overview]
Message-ID: <3eb8505a-5fda-3f03-9463-70e045c75ceb@arm.com> (raw)
In-Reply-To: <835f21dd-4655-fb39-6d4a-f5d954a61b94@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On 11/07/2023 23:28, Jeff Law wrote:
>
>
> On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote:
>> Hi,
>>
>> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H
>> list, as insn-opinit.h is now required by internal-fn.h. This will
>> lead to insn-opinit.h, among the other OPTABS_H header files, being
>> installed in the plugin directory.
>>
>> Bootstrapped aarch64-unknown-linux-gnu.
>>
>> @Jakub: could you check to see if it also addresses PR 110284?
>>
>>
>> gcc/ChangeLog:
>>
>> PR 110610
>> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
> Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h
> and insn-codes.h and neither of those #include other headers do they?
>
>
Yeah, there was no particular reason other than I just felt the Makefile
structure sort of lend itself that way. I checked genopinit.cc and it
seems insn-opinit.h doesn't include any other header files, only the
sources do, so I've changed the patch to only add insn-opinit.h to
INTERNAL_FN_H.
-------------------
This patch fixes PR110610 by including insn-opinit.h in the
INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h.
This will lead to insn-opinit.h, among the other OPTABS_H header files,
being installed in the plugin directory.
Bootstrapped aarch64-unknown-linux-gnu.
gcc/ChangeLog:
PR 110610
* Makefile.in (INTERNAL_FN_H): Add insn-opinit.h.
[-- Attachment #2: pr110610_2.patch --]
[-- Type: text/plain, Size: 658 bytes --]
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index c478ec852013eae65b9f3ec0a443e023c7d8b452..683774ad446d545362644d2dbdc37723eea55bc3 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h
BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \
gtm-builtins.def sanitizer.def
INTERNAL_FN_DEF = internal-fn.def
-INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF)
+INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) insn-opinit.h
TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \
c-family/c-common.def $(lang_tree_files) \
$(BUILTINS_DEF) $(INPUT_H) statistics.h \
next prev parent reply other threads:[~2023-07-17 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 10:37 Andre Vieira (lists)
2023-07-11 22:28 ` Jeff Law
2023-07-17 11:55 ` Andre Vieira (lists) [this message]
2023-07-17 14:27 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eb8505a-5fda-3f03-9463-70e045c75ceb@arm.com \
--to=andre.simoesdiasvieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).