public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Stubbs <ams@baylibre.com>
To: Frederik Harwath <frederik@harwath.name>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] amdgcn: Add gfx90c target
Date: Fri, 26 Apr 2024 09:56:57 +0100	[thread overview]
Message-ID: <efa4f3e8-9da1-4216-98d1-5da5b8e91e4e@baylibre.com> (raw)
In-Reply-To: <cd9a5716-f0d6-4999-ba0c-0510e4efbb9c@harwath.name>

On 25/04/2024 19:37, Frederik Harwath wrote:
> Hi Andrew,
> this patch adds support for gfx90c GCN5 APU integrated graphics devices.
> The LLVM AMDGPU documentation (https://llvm.org/docs/AMDGPUUsage.html)
> lists those devices as unsupported by rocm-amdhsa.
> As we have discussed elsewhere, I have tested the patch on an AMD Ryzen
> 5 5500U (also with different xnack settings) that I have and it passes
> most libgomp offloading tests.
> Although those APUs are very constrainted compared to dGPUs, I think
> they might be interesting for learning, experimentation, and testing.
> 
> 
> Can I commit the patch to the master branch?

OK, please go ahead.

Thanks for expanding our device support even further! :)

Andrew

  reply	other threads:[~2024-04-26  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 18:37 Frederik Harwath
2024-04-26  8:56 ` Andrew Stubbs [this message]
2024-04-26 10:41   ` [wwwdocs] gcc-14/changes.html (AMD GCN): Mention gfx90c support Andrew Stubbs
2024-04-26 10:42   ` Andrew Stubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efa4f3e8-9da1-4216-98d1-5da5b8e91e4e@baylibre.com \
    --to=ams@baylibre.com \
    --cc=frederik@harwath.name \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).