From: Robin Dapp <rdapp.gcc@gmail.com>
To: Palmer Dabbelt <palmer@rivosinc.com>,
gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai
Subject: Re: [PATCH v2] RISC-V: Add vector_scalar_shift_operand
Date: Fri, 12 May 2023 08:12:33 +0200 [thread overview]
Message-ID: <f2bb2cc2-e9a9-dbb9-fa6e-7f9362544cdf@gmail.com> (raw)
In-Reply-To: <20230511222848.15044-1-palmer@rivosinc.com>
> The vector shift immediates happen to have the same constraints as some
> of the CSR-related operands, but it's a different usage. This adds a
> name for them, so I don't get confused again next time.
>
> gcc/ChangeLog:
>
> * config/riscv/autovec.md (shifts): Use
> vector_scalar_shift_operand.
> * config/riscv/predicates.md (vector_scalar_shift_operand): New
> predicate.
Hehe, I had something similarly named in the first patch iteration
but removed it later. Helps clarity though so fair enough.
prev parent reply other threads:[~2023-05-12 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 22:28 Palmer Dabbelt
2023-05-12 1:32 ` Kito Cheng
2023-05-12 6:12 ` Robin Dapp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2bb2cc2-e9a9-dbb9-fa6e-7f9362544cdf@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).