* [PATCH] testsuite: constraint some of fp tests to hard_float
@ 2022-05-30 3:53 Vineet Gupta
2022-06-26 19:05 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Vineet Gupta @ 2022-05-30 3:53 UTC (permalink / raw)
To: gcc-patches
Cc: Kito Cheng, Philipp Tomsich, Palmer Dabbelt,
Christoph Müllner, gnu-toolchain, Andrew Waterman,
Maciej W . Rozycki, Jim Wilson, Vineet Gupta
These tests validate fp conversions with various rounding modes which
would not work on soft-float ABIs.
On -march=rv64imac/-mabi=lp64 this reduces 5 unique failures (overall 35
due to multi flag combination builds)
gcc/testsuite/Changelog:
* gcc.dg/torture/fp-double-convert-float-1.c: Add
dg-require-effective-target hard_float.
* gcc.dg/torture/fp-int-convert-timode-3.c: Ditto.
* gcc.dg/torture/fp-int-convert-timode-4.c: Ditto.
* gcc.dg/torture/fp-uint64-convert-double-1.c: Ditto.
* gcc.dg/torture/fp-uint64-convert-double-2.c: Ditto.
Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
gcc/testsuite/gcc.dg/torture/fp-double-convert-float-1.c | 1 +
gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c | 1 +
gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c | 1 +
gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c | 1 +
gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/gcc/testsuite/gcc.dg/torture/fp-double-convert-float-1.c b/gcc/testsuite/gcc.dg/torture/fp-double-convert-float-1.c
index ec23274ea989..1c28a9e101eb 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-double-convert-float-1.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-double-convert-float-1.c
@@ -1,6 +1,7 @@
/* PR57245 */
/* { dg-do run } */
/* { dg-require-effective-target fenv } */
+/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
index 707d539335fe..6f9a8d3f0d3e 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
@@ -3,6 +3,7 @@
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
/* { dg-require-effective-target fenv } */
+/* { dg-require-effective-target hard_float } */
/* { dg-options "-frounding-math" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
index 09600f909031..15f478d15e24 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
@@ -3,6 +3,7 @@
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
/* { dg-require-effective-target fenv } */
+/* { dg-require-effective-target hard_float } */
/* { dg-options "-frounding-math" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
index fadad8c31981..0c7bf003e93e 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
@@ -1,6 +1,7 @@
/* PR84407 */
/* { dg-do run } */
/* { dg-require-effective-target fenv } */
+/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math -fexcess-precision=standard" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
index 952f96b33c92..ac24b351a46d 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
@@ -1,6 +1,7 @@
/* PR84407 */
/* { dg-do run } */
/* { dg-require-effective-target fenv } */
+/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math" } */
#include <fenv.h>
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: constraint some of fp tests to hard_float
2022-05-30 3:53 [PATCH] testsuite: constraint some of fp tests to hard_float Vineet Gupta
@ 2022-06-26 19:05 ` Jeff Law
2022-07-14 4:28 ` Vineet Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2022-06-26 19:05 UTC (permalink / raw)
To: gcc-patches
On 5/29/2022 9:53 PM, Vineet Gupta wrote:
> These tests validate fp conversions with various rounding modes which
> would not work on soft-float ABIs.
>
> On -march=rv64imac/-mabi=lp64 this reduces 5 unique failures (overall 35
> due to multi flag combination builds)
>
> gcc/testsuite/Changelog:
> * gcc.dg/torture/fp-double-convert-float-1.c: Add
> dg-require-effective-target hard_float.
> * gcc.dg/torture/fp-int-convert-timode-3.c: Ditto.
> * gcc.dg/torture/fp-int-convert-timode-4.c: Ditto.
> * gcc.dg/torture/fp-uint64-convert-double-1.c: Ditto.
> * gcc.dg/torture/fp-uint64-convert-double-2.c: Ditto.
Thanks. I've pushed this to the trunk.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: constraint some of fp tests to hard_float
2022-06-26 19:05 ` Jeff Law
@ 2022-07-14 4:28 ` Vineet Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Vineet Gupta @ 2022-07-14 4:28 UTC (permalink / raw)
To: Jeff Law, gcc-patches
Hi Jeff,
On 6/26/22 12:05, Jeff Law via Gcc-patches wrote:
>
>
> On 5/29/2022 9:53 PM, Vineet Gupta wrote:
>> These tests validate fp conversions with various rounding modes which
>> would not work on soft-float ABIs.
>>
>> On -march=rv64imac/-mabi=lp64 this reduces 5 unique failures (overall 35
>> due to multi flag combination builds)
>>
>> gcc/testsuite/Changelog:
>> * gcc.dg/torture/fp-double-convert-float-1.c: Add
>> dg-require-effective-target hard_float.
>> * gcc.dg/torture/fp-int-convert-timode-3.c: Ditto.
>> * gcc.dg/torture/fp-int-convert-timode-4.c: Ditto.
>> * gcc.dg/torture/fp-uint64-convert-double-1.c: Ditto.
>> * gcc.dg/torture/fp-uint64-convert-double-2.c: Ditto.
> Thanks. I've pushed this to the trunk.
Can this be backported to gcc-12 please.
Thx,
-Vineet
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-14 4:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 3:53 [PATCH] testsuite: constraint some of fp tests to hard_float Vineet Gupta
2022-06-26 19:05 ` Jeff Law
2022-07-14 4:28 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).