From: Robin Dapp <rdapp.gcc@gmail.com>
To: Lehua Ding <lehua.ding@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rdapp.gcc@gmail.com, palmer <palmer@dabbelt.com>,
Kito Cheng <kito.cheng@gmail.com>,
jeffreyalaw <jeffreyalaw@gmail.com>,
"juzhe.zhong" <juzhe.zhong@rivai.ai>
Subject: Re: [PATCH v3] RISC-V: Add autovec FP binary operations.
Date: Wed, 6 Sep 2023 15:27:13 +0200 [thread overview]
Message-ID: <f99ec051-6021-1885-5a1f-a4757289e657@gmail.com> (raw)
In-Reply-To: <5D71367462E7C90B+1c5abca3-4b8d-4bbd-8565-121586dd1e18@rivai.ai>
Hi Lehua,
> May I ask if the compiler options "-march=rv64gcv_zvfh -mabi=lp64d"
> should be removed? Because we don't specify -march and -mabi when we
> run testcase (so but why we need to specify the -march and -mabi in
> this target check?), we run it with the default values. Assuming that
> the default is rv64gcv_zvfh_zfh, `riscv_vector` check will fail
> because compile and link with -march=rv64gcv will throw the following
> error if I doesn't compile a multilibs compilers. But in fact
> rv64gcv_zvfh_zfh contains rv64gcv, we should not let this case report
> link error.:
Yes, you're right, this should not be necessary. This is more of a
test for the execution environment than the compiler. I think Juzhe
removed it already in his patch that enables the vector test suite.
In the future we would use the checks that Joern added, not sure if
they are already upstream.
Regards
Robin
next prev parent reply other threads:[~2023-09-06 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 15:28 [PATCH] " Robin Dapp
2023-06-15 15:10 ` [PATCH v2] " Robin Dapp
2023-06-15 16:33 ` Michael Collison
2023-06-16 12:41 ` Robin Dapp
2023-06-16 6:58 ` juzhe.zhong
2023-06-16 7:31 ` Robin Dapp
[not found] ` <3593152A4AF6C445+E892D494-DF60-4B27-928D-14A269989B2B@rivai.ai>
2023-06-16 13:29 ` [PATCH v3] " Robin Dapp
2023-09-06 9:43 ` Lehua Ding
2023-09-06 13:27 ` Robin Dapp [this message]
2023-09-07 3:25 ` Lehua Ding
[not found] ` <1609CD82F4EC3898+30AECC2C-6966-43A1-854C-C14F08E5D45B@rivai.ai>
2023-06-17 2:20 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99ec051-6021-1885-5a1f-a4757289e657@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=lehua.ding@rivai.ai \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).