public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Vineet Gupta <vineetg@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: kito.cheng@gmail.com, Palmer Dabbelt <palmer@rivosinc.com>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Christoph Mullner <christoph.muellner@vrull.eu>,
	gnu-toolchain@rivosinc.co
Subject: Re: [Committed] riscv: relax splitter restrictions for creating pseudos
Date: Tue, 25 Apr 2023 15:35:05 -0600	[thread overview]
Message-ID: <fbba6560-2fd3-d43c-28e1-4969c95d6907@gmail.com> (raw)
In-Reply-To: <a9018457-e4db-e310-7bab-314003b4bd45@rivosinc.com>



On 4/25/23 14:20, Vineet Gupta wrote:
>> Just a note, there are some regressions in this table.  For example xz 
>> input #2.  So to be fair when making comparisons it's probably worth 
>> noting the regressions as well as improvements.
> 
> Fair point, but in my defense I dropped anything under 0.1 % (including 
> improvements).
No worries.


>> Anyway, my results are in line with yours. Given the instruction 
>> counts and known IPC, I think we're taking about a 2.5% hit on 
>> deepsjeng and about a 1% hit on leela and x264#2 comparing our 
>> internal gcc-12 vs gcc-13 trees.
> 
> I think you are referring to the bigger deepsjeng regression due to 
> commit 2e886eef7f2b5a which introduced the splitter movconst_internal. 
> This patch is about a small improvement to all splitters which reduces 
> that perf loss slightly (but does regress some tests too as pointed above).
Correct.  I'm referring to the larger gcc-12 to gcc-13 comparison, not 
your patch in my comment about regressions.  Sorry for not being clear 
about that.


Jeff

      reply	other threads:[~2023-04-25 21:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 14:36 [PATCH] " Vineet Gupta
2023-04-18 15:07 ` [PATCH v2] " Vineet Gupta
2023-04-18 18:36 ` [PATCH] " Jeff Law
2023-04-18 19:02   ` Vineet Gupta
2023-04-25 17:25   ` [Committed] " Vineet Gupta
2023-04-25 20:03     ` Jeff Law
2023-04-25 20:20       ` Vineet Gupta
2023-04-25 21:35         ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbba6560-2fd3-d43c-28e1-4969c95d6907@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=christoph.muellner@vrull.eu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.co \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@rivosinc.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).