From: Jason Merrill <jason@redhat.com>
To: Eugene Rozenfeld <Eugene.Rozenfeld@microsoft.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Andi Kleen <ak@linux.intel.com>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [EXTERNAL] Re: [PING][PATCH] Add instruction level discriminator support.
Date: Mon, 26 Sep 2022 17:22:24 -0400 [thread overview]
Message-ID: <fc916ba3-9619-b4e9-00c2-9025f170f08e@redhat.com> (raw)
In-Reply-To: <CY5PR21MB35429A8B20254344DFE44C2791439@CY5PR21MB3542.namprd21.prod.outlook.com>
On 9/8/22 20:45, Eugene Rozenfeld wrote:
> Jason,
>
> Thank for your suggestion. The patch is updated (attached).
> @@ -467,12 +471,19 @@ lto_location_cache::apply_location_cache ()
> current_loc = set_block (current_loc, loc.block);
> else
> current_loc = LOCATION_LOCUS (current_loc);
> + if (loc.discr)
> + current_loc = location_with_discriminator (current_loc, loc.discr);
> + }
> + else if (current_discr != loc.discr)
> + {
> + current_loc = location_with_discriminator (current_loc, loc.discr);
> }
We usually don't use { } around a single line.
> @@ -1180,6 +1206,7 @@ assign_discriminators (void)
> location_t locus = last ? gimple_location (last) : UNKNOWN_LOCATION;
>
> if (locus == UNKNOWN_LOCATION)
> +
> continue;
Stray newline.
OK with those tweaks.
Jason
prev parent reply other threads:[~2022-09-26 21:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 19:03 Eugene Rozenfeld
2022-06-27 19:45 ` Eugene Rozenfeld
2022-08-04 0:25 ` Eugene Rozenfeld
2022-08-19 1:55 ` Jason Merrill
2022-09-01 20:48 ` [EXTERNAL] " Eugene Rozenfeld
2022-09-01 22:22 ` Eugene Rozenfeld
2022-09-08 17:25 ` Jason Merrill
2022-09-09 0:45 ` Eugene Rozenfeld
2022-09-19 22:13 ` Eugene Rozenfeld
2022-09-26 21:22 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc916ba3-9619-b4e9-00c2-9025f170f08e@redhat.com \
--to=jason@redhat.com \
--cc=Eugene.Rozenfeld@microsoft.com \
--cc=ak@linux.intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).