public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Chung-Lin Tang <cltang@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>,
	Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	Catherine Moore <clm@codesourcery.com>
Subject: Re: [PATCH, v5, OpenMP 5.0] Improve OpenMP target support for C++ [PR92120 v5]
Date: Fri, 10 Dec 2021 00:41:59 +0800	[thread overview]
Message-ID: <fc9e445b-5f4e-9736-3327-5e1d7b41121c@codesourcery.com> (raw)
In-Reply-To: <20211203164706.GT2646553@tucnak>



On 2021/12/4 12:47 AM, Jakub Jelinek wrote:
> On Tue, Nov 16, 2021 at 08:43:27PM +0800, Chung-Lin Tang wrote:
>> 2021-11-16  Chung-Lin Tang  <cltang@codesourcery.com>
>>
>> 	PR middle-end/92120
>>
>> gcc/cp/ChangeLog:
>>
...
>> +	  if (allow_zero_length_array_sections)
>> +	    {
>> +	      /* When allowing attachment to zero-length array sections, we
>> +		 allow attaching to NULL pointers when the target region is not
>> +		 mapped.  */
>> +	      data = 0;
>> +	    }
> 
> No {}s around single statement if body.
> 
> Otherwise LGTM.
> 
> 	Jakub
> 

Thanks for the review and approval, Jakub.

Thomas, I pushed another 2766448c5cc3efc4 commit to fix the non-offload config FAILs, just FYI.

Chung-Lin





  reply	other threads:[~2021-12-09 16:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 14:25 [PATCH, OpenMP 5.0] Improve OpenMP target support for C++ [PR92120 v4] Chung-Lin Tang
2021-06-24 13:15 ` Jakub Jelinek
2021-11-16 12:43   ` [PATCH, v5, OpenMP 5.0] Improve OpenMP target support for C++ [PR92120 v5] Chung-Lin Tang
2021-12-03 16:47     ` Jakub Jelinek
2021-12-09 16:41       ` Chung-Lin Tang [this message]
2022-09-07  7:04     ` [committed] openmp: Fix handling of target constructs in static member functions [PR106829] Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc9e445b-5f4e-9736-3327-5e1d7b41121c@codesourcery.com \
    --to=cltang@codesourcery.com \
    --cc=clm@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).