Re: [PATCH] tree-optimization/108522 Use component_ref_field_offset

[Siddhesh Poyarekar <siddhesh@gotplt.org>]

On 2023-01-25 22:32, Siddhesh Poyarekar wrote:
> Instead of using TREE_OPERAND (expr, 2) directly, use
> component_ref_field_offset instead, which does scaling for us.  The
> function also substitutes PLACEHOLDER_EXPRs, which is probably what we
> want anyway but I'm not sure if it's relevant for tree-object-size.
> 
> gcc/ChangeLog:
> 
> 	PR tree-optimization/108522
> 	* tree-object-size.cc (compute_object_offset): Make EXPR
> 	argument non-const.  Call component_ref_field_offset.
> 
> gcc/testsuite/ChangeLog:
> 
> 	PR tree-optimization/108522
> 	* gcc.dg/builtin-dynamic-object-size-0.c (DEFSTRUCT): New
> 	macro.
> 	(test_dynarray_struct_member_b, test_dynarray_struct_member_c,
> 	test_dynarray_struct_member_d,
> 	test_dynarray_struct_member_subobj_b,
> 	test_dynarray_struct_member_subobj_c,
> 	test_dynarray_struct_member_subobj_d): New tests.
> 	(main): Call them.
> 
> Signed-off-by: Siddhesh Poyarekar <siddhesh@gotplt.org>

... and now pushed (this and the earlier commit) to gcc-12 branch.

Sid