From: Andrea Corallo <andrea.corallo@arm.com>
To: Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Alexandre Oliva <oliva@adacore.com>, <nickc@redhat.com>,
<richard.earnshaw@arm.com>, <ramana.gcc@gmail.com>,
<kyrylo.tkachov@arm.com>
Subject: Re: [PATCH] [PR104882] [arm] require mve hw for mve run test
Date: Mon, 20 Feb 2023 11:05:35 +0100 [thread overview]
Message-ID: <gkrlekswt1s.fsf@arm.com> (raw)
In-Reply-To: <ory1owrbaj.fsf@lxoliva.fsfla.org> (Alexandre Oliva via Gcc-patches's message of "Fri, 17 Feb 2023 04:39:00 -0300")
Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> The pr104882.c test is an execution test, but arm_v8_1m_mve_ok only
> tests for compile-time support. Add a requirement for mve hardware.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
>
> for gcc/testsuite/ChangeLog
>
> PR target/104882
> * gcc.target/arm/simd/pr104882.c: Require mve hardware.
> ---
> gcc/testsuite/gcc.target/arm/simd/pr104882.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/arm/simd/pr104882.c b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> index ae9709af42f22..1ea7a14836f54 100644
> --- a/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> +++ b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> @@ -1,4 +1,5 @@
> /* { dg-do run } */
> +/* { dg-require-effective-target arm_mve_hw } */
> /* { dg-require-effective-target arm_v8_1m_mve_ok } */
> /* { dg-add-options arm_v8_1m_mve } */
> /* { dg-additional-options "-O2" } */
Hi Alexandre,
no approver here but LGTM, thanks.
Andrea
next prev parent reply other threads:[~2023-02-20 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:39 Alexandre Oliva
2023-02-20 10:05 ` Andrea Corallo [this message]
2023-03-03 8:26 ` Alexandre Oliva
2023-03-03 9:08 ` Kyrylo Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gkrlekswt1s.fsf@arm.com \
--to=andrea.corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=nickc@redhat.com \
--cc=oliva@adacore.com \
--cc=ramana.gcc@gmail.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).