public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] [PR104882] [arm] require mve hw for mve run test
@ 2023-02-17  7:39 Alexandre Oliva
  2023-02-20 10:05 ` Andrea Corallo
  2023-03-03  9:08 ` Kyrylo Tkachov
  0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Oliva @ 2023-02-17  7:39 UTC (permalink / raw)
  To: gcc-patches; +Cc: nickc, richard.earnshaw, ramana.gcc, kyrylo.tkachov


The pr104882.c test is an execution test, but arm_v8_1m_mve_ok only
tests for compile-time support.  Add a requirement for mve hardware.

Regstrapped on x86_64-linux-gnu.
Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk).  Ok to install?

for  gcc/testsuite/ChangeLog

	PR target/104882
	* gcc.target/arm/simd/pr104882.c: Require mve hardware.
---
 gcc/testsuite/gcc.target/arm/simd/pr104882.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.target/arm/simd/pr104882.c b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
index ae9709af42f22..1ea7a14836f54 100644
--- a/gcc/testsuite/gcc.target/arm/simd/pr104882.c
+++ b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
@@ -1,4 +1,5 @@
 /* { dg-do run } */
+/* { dg-require-effective-target arm_mve_hw } */
 /* { dg-require-effective-target arm_v8_1m_mve_ok } */
 /* { dg-add-options arm_v8_1m_mve } */
 /* { dg-additional-options "-O2" } */

-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [PR104882] [arm] require mve hw for mve run test
  2023-02-17  7:39 [PATCH] [PR104882] [arm] require mve hw for mve run test Alexandre Oliva
@ 2023-02-20 10:05 ` Andrea Corallo
  2023-03-03  8:26   ` Alexandre Oliva
  2023-03-03  9:08 ` Kyrylo Tkachov
  1 sibling, 1 reply; 4+ messages in thread
From: Andrea Corallo @ 2023-02-20 10:05 UTC (permalink / raw)
  To: Alexandre Oliva via Gcc-patches
  Cc: Alexandre Oliva, nickc, richard.earnshaw, ramana.gcc, kyrylo.tkachov

Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> writes:

> The pr104882.c test is an execution test, but arm_v8_1m_mve_ok only
> tests for compile-time support.  Add a requirement for mve hardware.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk).  Ok to install?
>
> for  gcc/testsuite/ChangeLog
>
> 	PR target/104882
> 	* gcc.target/arm/simd/pr104882.c: Require mve hardware.
> ---
>  gcc/testsuite/gcc.target/arm/simd/pr104882.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/arm/simd/pr104882.c b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> index ae9709af42f22..1ea7a14836f54 100644
> --- a/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> +++ b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run } */
> +/* { dg-require-effective-target arm_mve_hw } */
>  /* { dg-require-effective-target arm_v8_1m_mve_ok } */
>  /* { dg-add-options arm_v8_1m_mve } */
>  /* { dg-additional-options "-O2" } */

Hi Alexandre,

no approver here but LGTM, thanks.

  Andrea

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [PR104882] [arm] require mve hw for mve run test
  2023-02-20 10:05 ` Andrea Corallo
@ 2023-03-03  8:26   ` Alexandre Oliva
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Oliva @ 2023-03-03  8:26 UTC (permalink / raw)
  To: nickc, richard.earnshaw, ramana.gcc, kyrylo.tkachov
  Cc: Alexandre Oliva via Gcc-patches, Andrea Corallo

On Feb 20, 2023, Andrea Corallo <andrea.corallo@arm.com> wrote:

> Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>> PR target/104882
>> * gcc.target/arm/simd/pr104882.c: Require mve hardware.

> no approver here but LGTM, thanks.

Ping?
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612194.html

-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] [PR104882] [arm] require mve hw for mve run test
  2023-02-17  7:39 [PATCH] [PR104882] [arm] require mve hw for mve run test Alexandre Oliva
  2023-02-20 10:05 ` Andrea Corallo
@ 2023-03-03  9:08 ` Kyrylo Tkachov
  1 sibling, 0 replies; 4+ messages in thread
From: Kyrylo Tkachov @ 2023-03-03  9:08 UTC (permalink / raw)
  To: Alexandre Oliva, gcc-patches; +Cc: nickc, Richard Earnshaw, ramana.gcc



> -----Original Message-----
> From: Alexandre Oliva <oliva@adacore.com>
> Sent: Friday, February 17, 2023 7:39 AM
> To: gcc-patches@gcc.gnu.org
> Cc: nickc@redhat.com; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> ramana.gcc@gmail.com; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> Subject: [PATCH] [PR104882] [arm] require mve hw for mve run test
> 
> 
> The pr104882.c test is an execution test, but arm_v8_1m_mve_ok only
> tests for compile-time support.  Add a requirement for mve hardware.
> 
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk).  Ok to install?

Ok.
Thanks,
Kyrill

> 
> for  gcc/testsuite/ChangeLog
> 
> 	PR target/104882
> 	* gcc.target/arm/simd/pr104882.c: Require mve hardware.
> ---
>  gcc/testsuite/gcc.target/arm/simd/pr104882.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> index ae9709af42f22..1ea7a14836f54 100644
> --- a/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> +++ b/gcc/testsuite/gcc.target/arm/simd/pr104882.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run } */
> +/* { dg-require-effective-target arm_mve_hw } */
>  /* { dg-require-effective-target arm_v8_1m_mve_ok } */
>  /* { dg-add-options arm_v8_1m_mve } */
>  /* { dg-additional-options "-O2" } */
> 
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-03-03  9:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17  7:39 [PATCH] [PR104882] [arm] require mve hw for mve run test Alexandre Oliva
2023-02-20 10:05 ` Andrea Corallo
2023-03-03  8:26   ` Alexandre Oliva
2023-03-03  9:08 ` Kyrylo Tkachov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).