From: Andrea Corallo <andrea.corallo@arm.com>
To: Andrea Corallo via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: <kyrylo.tkachov@arm.com>, <Richard.Earnshaw@arm.com>,
<richard.sandiford@arm.com>
Subject: Re: [PATCH] aarch64: Fix return_address_sign_ab_exception.C regression
Date: Wed, 8 Feb 2023 15:36:50 +0100 [thread overview]
Message-ID: <gkrv8kckyv1.fsf@arm.com> (raw)
In-Reply-To: <mptwn4u7s07.fsf@arm.com> (Richard Sandiford's message of "Mon, 06 Feb 2023 15:06:32 +0000")
Richard Sandiford <richard.sandiford@arm.com> writes:
> Andrea Corallo via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>> Hi all,
>>
>> this is to fix the regression of
>> g++.target/aarch64/return_address_sign_ab_exception.C that I
>> introduced with d8dadbc9a5199bf7bac1ab7376b0f84f45e94350.
>>
>> 'aarch_ra_sign_key' for aarch64 ended up being non defined in the opt
>> file and the function attribute "branch-protection=pac-ret+leaf+b-key"
>> stopped working as expected.
>>
>> This patch moves the definition of 'aarch_ra_sign_key' to the opt
>> files for both Arm back-ends.
>>
>> Regards
>>
>> Andera Corallo
>>
>> gcc/ChangeLog:
>>
>> * config/aarch64/aarch64-protos.h (aarch_ra_sign_key): Remove
>> declaration.
>> * config/aarch64/aarch64.cc (aarch_ra_sign_key): Remove
>> definition.
>> * config/aarch64/aarch64.opt (aarch64_ra_sign_key): Rename
>> to 'aarch_ra_sign_key'.
>> * config/arm/aarch-common.cc (aarch_ra_sign_key): Remove
>> declaration.
>> * config/arm/arm-protos.h (aarch_ra_sign_key): Likewise.
>> * config/arm/arm.cc (enum aarch_key_type): Remove definition.
>> * config/arm/arm.opt: Define.
>
> OK, thanks.
>
> Richard
Thanks for reviewing, in as b1d26458839.
Best Regards
Andrea
prev parent reply other threads:[~2023-02-08 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 14:47 Andrea Corallo
2023-02-06 15:06 ` Richard Sandiford
2023-02-08 14:36 ` Andrea Corallo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gkrv8kckyv1.fsf@arm.com \
--to=andrea.corallo@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).