From: Tom Tromey <tromey@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Raw strings (take 3)
Date: Tue, 13 Oct 2009 17:24:00 -0000 [thread overview]
Message-ID: <m3vdijjjm6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20091013140022.GS14664@tyan-ft48-01.lab.bos.redhat.com> (Jakub Jelinek's message of "Tue, 13 Oct 2009 16:00:22 +0200")
>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
Tom> Would it be too much trouble to use calls to cpp_error_with_line for all
Tom> new errors? I think this is generally preferable, and in this code I
Tom> think it would also let us emit errors against locations inside strings.
Tom> (And, for errors about unterminated strings, it would let us point to
Tom> the start of the string, which seems better to me.)
Jakub> Done.
Thanks!
Jakub> 2009-10-13 Jakub Jelinek <jakub@redhat.com>
Jakub> * charset.c (cpp_init_iconv): Initialize utf8_cset_desc.
[...]
The parts of this that I can approve are ok.
Thanks again.
Tom
prev parent reply other threads:[~2009-10-13 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 12:37 Patch ping Jakub Jelinek
2009-10-12 19:23 ` Tom Tromey
2009-10-12 20:21 ` Jakub Jelinek
2009-10-12 21:29 ` Tom Tromey
2009-10-13 14:05 ` [PATCH] Raw strings (take 3) Jakub Jelinek
2009-10-13 17:24 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdijjjm6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).