From: Palmer Dabbelt <palmer@dabbelt.com>
To: jinma@linux.alibaba.com
Cc: zengxiao@eswincomputing.com, gcc-patches@gcc.gnu.org,
jeffreyalaw@gmail.com, research_trasio@irq.a4lg.com,
Kito Cheng <kito.cheng@gmail.com>,
zhengyu@eswincomputing.com
Subject: Re:[PATCH v2 1/1] [RISC-V] Add support for _Bfloat16
Date: Tue, 02 Apr 2024 20:43:26 -0700 (PDT) [thread overview]
Message-ID: <mhng-0e1ba603-edb9-481a-a952-e64f9e200765@palmer-ri-x1c9> (raw)
In-Reply-To: <e0629858-a356-431e-8004-3f58d8b08d67.jinma@linux.alibaba.com>
On Tue, 02 Apr 2024 20:19:16 PDT (-0700), jinma@linux.alibaba.com wrote:
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/riscv/bf16_arithmetic.c: New test.
>> * gcc.target/riscv/bf16_call.c: New test.
>> * gcc.target/riscv/bf16_comparison.c: New test.
>> * gcc.target/riscv/bf16_float_libcall_convert.c: New test.
>> * gcc.target/riscv/bf16_integer_libcall_convert.c: New test.
>
> Hi, I have test this patch and it is very good. I think we need to add some
> runable tests to ensure that the results are right for various types of
> conversions, operations, and libfuncs.
Sorry I forgot to reply earlier, a few of us were talking about this is
the patchwork meeting this morning. We think this is too big for GCC-14
this late in the cycle. Folks are still looking at bugs, so it might
take a bit to get reviewed for GCC-15.
I took a look and don't see anything wrong, but I'm not a floating-point
person so I'd want to try and talk to someone who is before committing
it.
More testing never hurts, though ;)
>
> BR,
> Jin
next prev parent reply other threads:[~2024-04-03 3:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 9:22 [PATCH v2 0/1] " Xiao Zeng
2024-04-02 9:22 ` [PATCH v2 1/1] " Xiao Zeng
2024-04-03 3:19 ` Jin Ma
2024-04-03 3:43 ` Palmer Dabbelt [this message]
2024-04-03 6:16 ` Xiao Zeng
2024-05-04 15:23 ` [PATCH " Jeff Law
2024-05-05 2:08 ` Xiao Zeng
2024-05-06 21:06 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-0e1ba603-edb9-481a-a952-e64f9e200765@palmer-ri-x1c9 \
--to=palmer@dabbelt.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jinma@linux.alibaba.com \
--cc=kito.cheng@gmail.com \
--cc=research_trasio@irq.a4lg.com \
--cc=zengxiao@eswincomputing.com \
--cc=zhengyu@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).