* [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase
@ 2023-12-06 0:39 Edwin Lu
2023-12-06 16:22 ` Palmer Dabbelt
0 siblings, 1 reply; 5+ messages in thread
From: Edwin Lu @ 2023-12-06 0:39 UTC (permalink / raw)
To: gcc-patches; +Cc: gnu-toolchain, Edwin Lu
Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail
was introduced. The test did pass at that hash and has continued to pass since
then. Remove the xfail
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/ssa-fre-3.c: Remove xfail
Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
---
gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
index 224dd4f72ef..b2924837a22 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
@@ -18,4 +18,4 @@ foo (int a, int b)
return aa + bb;
}
-/* { dg-final { scan-tree-dump "Replaced \\\(int\\\) aa_.*with a_" "fre1" { xfail { riscv*-*-* && lp64 } } } } */
+/* { dg-final { scan-tree-dump "Replaced \\\(int\\\) aa_.*with a_" "fre1" } } */
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase
2023-12-06 0:39 [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase Edwin Lu
@ 2023-12-06 16:22 ` Palmer Dabbelt
2023-12-06 18:48 ` Vineet Gupta
2023-12-07 19:18 ` [Committed] " Edwin Lu
0 siblings, 2 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2023-12-06 16:22 UTC (permalink / raw)
To: ewlu, Kito Cheng; +Cc: gcc-patches, gnu-toolchain, ewlu
On Tue, 05 Dec 2023 16:39:06 PST (-0800), ewlu@rivosinc.com wrote:
> Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail
That's the original port submission, I'm actually kind of surprised it
still builds/works at all.
> was introduced. The test did pass at that hash and has continued to pass since
> then. Remove the xfail
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/tree-ssa/ssa-fre-3.c: Remove xfail
>
> Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
> ---
> gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
> index 224dd4f72ef..b2924837a22 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
> @@ -18,4 +18,4 @@ foo (int a, int b)
> return aa + bb;
> }
>
> -/* { dg-final { scan-tree-dump "Replaced \\\(int\\\) aa_.*with a_" "fre1" { xfail { riscv*-*-* && lp64 } } } } */
> +/* { dg-final { scan-tree-dump "Replaced \\\(int\\\) aa_.*with a_" "fre1" } } */
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Though Kito did all the test suite stuff back then, so not sure if he
happens to remember anything specific about what was going on.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase
2023-12-06 16:22 ` Palmer Dabbelt
@ 2023-12-06 18:48 ` Vineet Gupta
2023-12-06 18:51 ` Palmer Dabbelt
2023-12-07 19:18 ` [Committed] " Edwin Lu
1 sibling, 1 reply; 5+ messages in thread
From: Vineet Gupta @ 2023-12-06 18:48 UTC (permalink / raw)
To: Palmer Dabbelt, ewlu, Kito Cheng; +Cc: gcc-patches, gnu-toolchain
On 12/6/23 08:22, Palmer Dabbelt wrote:
>> Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail
> That's the original port submission, I'm actually kind of surprised it
> still builds/works at all.
Full toolchain build would have been a stretch (matching pairing
binutils etc).
So I'd asked Edwin to just do a minimal cc1 build.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase
2023-12-06 18:48 ` Vineet Gupta
@ 2023-12-06 18:51 ` Palmer Dabbelt
0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2023-12-06 18:51 UTC (permalink / raw)
To: Vineet Gupta; +Cc: ewlu, Kito Cheng, gcc-patches, gnu-toolchain
On Wed, 06 Dec 2023 10:48:30 PST (-0800), Vineet Gupta wrote:
>
> On 12/6/23 08:22, Palmer Dabbelt wrote:
>>> Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where the xfail
>> That's the original port submission, I'm actually kind of surprised it
>> still builds/works at all.
>
> Full toolchain build would have been a stretch (matching pairing
> binutils etc).
> So I'd asked Edwin to just do a minimal cc1 build.
Ah, good idea. I've gotten hung up a bunch of times trying to reproduce
old stuff. I'd always been trying full toolchain builds, I bet cc1
would have a better chance of building for me.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Committed] RISC-V: Remove xfail from ssa-fre-3.c testcase
2023-12-06 16:22 ` Palmer Dabbelt
2023-12-06 18:48 ` Vineet Gupta
@ 2023-12-07 19:18 ` Edwin Lu
1 sibling, 0 replies; 5+ messages in thread
From: Edwin Lu @ 2023-12-07 19:18 UTC (permalink / raw)
To: Palmer Dabbelt, Kito Cheng; +Cc: gcc-patches, gnu-toolchain
Committed!
On 12/6/2023 8:22 AM, Palmer Dabbelt wrote:
> On Tue, 05 Dec 2023 16:39:06 PST (-0800), ewlu@rivosinc.com wrote:
>> Ran the test case at 122e7b4f9d0c2d54d865272463a1d812002d0a5c where
>> the xfail
>
> That's the original port submission, I'm actually kind of surprised it
> still builds/works at all.
>
>> was introduced. The test did pass at that hash and has continued to
>> pass since
>> then. Remove the xfail
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.dg/tree-ssa/ssa-fre-3.c: Remove xfail
>>
>> Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
>> ---
>> gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
>> b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
>> index 224dd4f72ef..b2924837a22 100644
>> --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
>> +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-3.c
>> @@ -18,4 +18,4 @@ foo (int a, int b)
>> return aa + bb;
>> }
>>
>> -/* { dg-final { scan-tree-dump "Replaced \\\(int\\\) aa_.*with a_"
>> "fre1" { xfail { riscv*-*-* && lp64 } } } } */
>> +/* { dg-final { scan-tree-dump "Replaced \\\(int\\\) aa_.*with a_"
>> "fre1" } } */
>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Though Kito did all the test suite stuff back then, so not sure if he
> happens to remember anything specific about what was going on.
>
> Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-07 19:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-06 0:39 [PATCH] RISC-V: Remove xfail from ssa-fre-3.c testcase Edwin Lu
2023-12-06 16:22 ` Palmer Dabbelt
2023-12-06 18:48 ` Vineet Gupta
2023-12-06 18:51 ` Palmer Dabbelt
2023-12-07 19:18 ` [Committed] " Edwin Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).