public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@rivosinc.com>
To: Kito Cheng <kito.cheng@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V
Date: Fri, 13 May 2022 09:53:58 -0700 (PDT)	[thread overview]
Message-ID: <mhng-9540256d-a08c-4d8e-994b-26c21bd57274@palmer-ri-x1c9> (raw)
In-Reply-To: <CA+yXCZDWEtFXecOR9_LwTw0UpKAQsUoCd7BMyD+gqXr8ZBs52Q@mail.gmail.com>

On Tue, 10 May 2022 18:31:37 PDT (-0700), Kito Cheng wrote:
> LGTM, that's only added a new option for RISC-V and won't affect all
> other targets, so I assume I can approve that.

I always forget what the rules are, but someone recently reminded me and 
yes that's the case.  I committed this.

Thanks!

>
> On Wed, May 4, 2022 at 8:27 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> Similar to 37e65643d3e ("testsuite/101269: fix testcase when used with
>> -m32"), RISC-V needs to be told not to put symbols in the
>> sdata/srodata/sbss sections.
>>
>> gcc/testsuite/ChangeLog
>>
>>         * debug/btf/btf-datasec-1.c: Don't use small data on RISC-V.
>> ---
>>  gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
>> index dbb236bbda1..77df88648c5 100644
>> --- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
>> +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
>> @@ -12,6 +12,7 @@
>>  /* { dg-do compile )  */
>>  /* { dg-options "-O0 -gbtf -dA" } */
>>  /* { dg-options "-O0 -gbtf -dA -msdata=none" { target { { powerpc*-*-* } && ilp32 } } } */
>> +/* { dg-options "-O0 -gbtf -dA -msmall-data-limit=0" { target { riscv*-*-* } } } */
>>  /* { dg-options "-O0 -gbtf -dA -G0" { target { nios2-*-* } } } */
>>
>>  /* Check for two DATASEC entries with vlen 3, and one with vlen 1.  */
>> --
>> 2.34.1
>>

  reply	other threads:[~2022-05-13 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  0:27 Palmer Dabbelt
2022-05-11  1:31 ` Kito Cheng
2022-05-13 16:53   ` Palmer Dabbelt [this message]
2022-09-10  4:10   ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-9540256d-a08c-4d8e-994b-26c21bd57274@palmer-ri-x1c9 \
    --to=palmer@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kito.cheng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).