From: Palmer Dabbelt <palmer@rivosinc.com>
To: richard.guenther@gmail.com
Cc: gcc-patches@gcc.gnu.org, hubicka@ucw.cz
Subject: Re: [PATCH] doc: -falign-functions doesn't override the __attribute__((align(N)))
Date: Tue, 11 Oct 2022 14:02:56 -0700 (PDT) [thread overview]
Message-ID: <mhng-f3c7456f-5ba9-4542-96b4-3bbd9b7bce84@palmer-ri-x1c9> (raw)
In-Reply-To: <CAFiYyc0vhyrcMz-aLkWf6nT8U+yBdHdPgNGtHmPkV-AwO9Ckmg@mail.gmail.com>
On Sun, 09 Oct 2022 23:07:21 PDT (-0700), richard.guenther@gmail.com wrote:
> On Fri, Oct 7, 2022 at 3:50 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> I found this when reading the documentation for Kito's recent patch.
>> From the discussion it sounds like this is the desired behavior, so
>> let's document it.
>
> Maybe also mention that the alignment doesn't apply to functions
> optimized for size?
Oops, I guess that was the whole point of the discussion ;). I sent a
v2, which also mentions -Os but not sure we need to do that explicitly.
>
>> gcc/doc/ChangeLog
>>
>> * invoke.texi (-falign-functions): Mention __align__
>> ---
>> gcc/doc/invoke.texi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index 2a9ea3455f6..8326a60dcf1 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -13136,7 +13136,9 @@ effective only in combination with @option{-fstrict-aliasing}.
>> Align the start of functions to the next power-of-two greater than or
>> equal to @var{n}, skipping up to @var{m}-1 bytes. This ensures that at
>> least the first @var{m} bytes of the function can be fetched by the CPU
>> -without crossing an @var{n}-byte alignment boundary.
>> +without crossing an @var{n}-byte alignment boundary. This does not override
>> +functions that otherwise specify their own alignment constraints, such as via
>> +an alignment attribute.
>>
>> If @var{m} is not specified, it defaults to @var{n}.
>>
>> --
>> 2.34.1
>>
prev parent reply other threads:[~2022-10-11 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 13:49 Palmer Dabbelt
2022-10-10 6:07 ` Richard Biener
2022-10-11 21:02 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-f3c7456f-5ba9-4542-96b4-3bbd9b7bce84@palmer-ri-x1c9 \
--to=palmer@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).