From: Richard Sandiford <richard.sandiford@arm.com>
To: Christophe Lyon <christophe.lyon@arm.com>
Cc: <gcc-patches@gcc.gnu.org>, <jakub@redhat.com>
Subject: Re: [PATCH 2/2] aarch64: add -fno-stack-protector to some tests [PR108411]
Date: Thu, 19 Jan 2023 09:23:04 +0000 [thread overview]
Message-ID: <mpt3586q3nr.fsf@arm.com> (raw)
In-Reply-To: <20230118201649.11612-2-christophe.lyon@arm.com> (Christophe Lyon's message of "Wed, 18 Jan 2023 21:16:49 +0100")
Christophe Lyon <christophe.lyon@arm.com> writes:
> As discussed in the PR, these recently added tests fail when the
> testsuite is executed with -fstack-protector-strong. To avoid this,
> this patch adds -fno-stack-protector to dg-options.
>
> PR target/108411
> gcc/testsuite
> * g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C: Add
> -fno-stack-protector.
> * g++.target/aarch64/bitfield-abi-warning-align16-O2.C: Likewise.
> * g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C: Likewise.
> * g++.target/aarch64/bitfield-abi-warning-align32-O2.C: Likewise.
> * g++.target/aarch64/bitfield-abi-warning-align8-O2.C: Likewise.
> * gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c: Likewise.
> * gcc.target/aarch64/bitfield-abi-warning-align16-O2.c: Likewise.
> * gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c: Likewise.
> * gcc.target/aarch64/bitfield-abi-warning-align32-O2.c: Likewise.
> * gcc.target/aarch64/bitfield-abi-warning-align8-O2.c: Likewise.
OK, thanks.
Richard
> ---
> .../g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C | 2 +-
> .../g++.target/aarch64/bitfield-abi-warning-align16-O2.C | 2 +-
> .../g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C | 2 +-
> .../g++.target/aarch64/bitfield-abi-warning-align32-O2.C | 2 +-
> .../g++.target/aarch64/bitfield-abi-warning-align8-O2.C | 2 +-
> .../gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c | 2 +-
> .../gcc.target/aarch64/bitfield-abi-warning-align16-O2.c | 2 +-
> .../gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c | 2 +-
> .../gcc.target/aarch64/bitfield-abi-warning-align32-O2.c | 2 +-
> .../gcc.target/aarch64/bitfield-abi-warning-align8-O2.c | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C
> index 443cd458b4c..52f9cdd1ee9 100644
> --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C
> +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */
>
> #define ALIGN 16
> //#define EXTRA
> diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C
> index 76a7e3d0ad4..9ff4e46645b 100644
> --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C
> +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */
>
> #define ALIGN 16
> #define EXTRA
> diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C
> index 6f8f54f41ff..55dcbfe4b7c 100644
> --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C
> +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */
>
> #define ALIGN 32
> //#define EXTRA
> diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C
> index 6b8ad5fbea1..6bb8778ee90 100644
> --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C
> +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */
>
> #define ALIGN 32
> #define EXTRA
> diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C
> index b1764d97ea0..41bcc894a2b 100644
> --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C
> +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */
>
> #define ALIGN 8
> #define EXTRA
> diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c
> index f248a129509..3b2c932ac23 100644
> --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c
> +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */
>
> #define ALIGN 16
> //#define EXTRA
> diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c
> index 22ee5ec4c92..ee5d6faa428 100644
> --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */
>
> #define ALIGN 16
> #define EXTRA
> diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c
> index a8a50b35e8e..6d4a883a96e 100644
> --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c
> +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */
>
> #define ALIGN 32
> //#define EXTRA
> diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c
> index e872de3dbe0..331daba354c 100644
> --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */
>
> #define ALIGN 32
> #define EXTRA
> diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c
> index cb2a945a819..e6d45f5dd5c 100644
> --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -save-temps" } */
> +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */
>
> #define ALIGN 8
> #define EXTRA
next prev parent reply other threads:[~2023-01-19 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 20:16 [PATCH 1/2] aarch64: fix ICE in aarch64_layout_arg [PR108411] Christophe Lyon
2023-01-18 20:16 ` [PATCH 2/2] aarch64: add -fno-stack-protector to some tests [PR108411] Christophe Lyon
2023-01-19 9:23 ` Richard Sandiford [this message]
2023-01-19 9:22 ` [PATCH 1/2] aarch64: fix ICE in aarch64_layout_arg [PR108411] Richard Sandiford
2023-01-19 14:24 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpt3586q3nr.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).