* [PATCH][gensupport]: Don't segfault on empty attrs list
@ 2023-08-02 10:29 Tamar Christina
2023-08-02 14:54 ` Richard Sandiford
0 siblings, 1 reply; 2+ messages in thread
From: Tamar Christina @ 2023-08-02 10:29 UTC (permalink / raw)
To: gcc-patches; +Cc: nd, richard.sandiford
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
Hi All,
Currently we segfault when len == 0 for an attribute list.
essentially [cons: =0, 1, 2, 3; attrs: ] segfaults but should be equivalent to
[cons: =0, 1, 2, 3] and [cons: =0, 1, 2, 3; attrs:]. This fixes it by just
returning early and leaving it to the validators whether this should error out
or not.
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
Ok for master?
Thanks,
Tamar
gcc/ChangeLog:
* gensupport.cc (conlist): Support length 0 attribute.
--- inline copy of patch --
diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
index 959d1d9c83cf397fcb344e8d3db0f339a967587f..5c5f1cf4781551d3db95103c19cd1b70d98f4f73 100644
--- a/gcc/gensupport.cc
+++ b/gcc/gensupport.cc
@@ -619,6 +619,9 @@ public:
[ns..ns + len) should equal XSTR (rtx, 0). */
conlist (const char *ns, unsigned int len, bool numeric)
{
+ if (len == 0)
+ return;
+
/* Trim leading whitespaces. */
while (ISBLANK (*ns))
{
--
[-- Attachment #2: rb17619.patch --]
[-- Type: text/plain, Size: 454 bytes --]
diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
index 959d1d9c83cf397fcb344e8d3db0f339a967587f..5c5f1cf4781551d3db95103c19cd1b70d98f4f73 100644
--- a/gcc/gensupport.cc
+++ b/gcc/gensupport.cc
@@ -619,6 +619,9 @@ public:
[ns..ns + len) should equal XSTR (rtx, 0). */
conlist (const char *ns, unsigned int len, bool numeric)
{
+ if (len == 0)
+ return;
+
/* Trim leading whitespaces. */
while (ISBLANK (*ns))
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][gensupport]: Don't segfault on empty attrs list
2023-08-02 10:29 [PATCH][gensupport]: Don't segfault on empty attrs list Tamar Christina
@ 2023-08-02 14:54 ` Richard Sandiford
0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2023-08-02 14:54 UTC (permalink / raw)
To: Tamar Christina; +Cc: gcc-patches, nd
Tamar Christina <tamar.christina@arm.com> writes:
> Hi All,
>
> Currently we segfault when len == 0 for an attribute list.
>
> essentially [cons: =0, 1, 2, 3; attrs: ] segfaults but should be equivalent to
> [cons: =0, 1, 2, 3] and [cons: =0, 1, 2, 3; attrs:]. This fixes it by just
> returning early and leaving it to the validators whether this should error out
> or not.
>
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master?
>
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> * gensupport.cc (conlist): Support length 0 attribute.
>
> --- inline copy of patch --
> diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
> index 959d1d9c83cf397fcb344e8d3db0f339a967587f..5c5f1cf4781551d3db95103c19cd1b70d98f4f73 100644
> --- a/gcc/gensupport.cc
> +++ b/gcc/gensupport.cc
> @@ -619,6 +619,9 @@ public:
> [ns..ns + len) should equal XSTR (rtx, 0). */
> conlist (const char *ns, unsigned int len, bool numeric)
> {
> + if (len == 0)
> + return;
> +
> /* Trim leading whitespaces. */
> while (ISBLANK (*ns))
> {
I think instead we should add some "len" guards to the while loops:
/* Trim leading whitespaces. */
while (len > 0 && ISBLANK (*ns))
{
ns++;
len--;
}
...
/* Parse off any modifiers. */
while (len > 0 && !ISALNUM (*ns))
{
con += *(ns++);
len--;
}
Otherwise we could crash for a string that only contains whitespace,
or that only contains non-alphnumeric characters.
OK like that if it works.
Thanks,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-02 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02 10:29 [PATCH][gensupport]: Don't segfault on empty attrs list Tamar Christina
2023-08-02 14:54 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).