* [PATCH] aarch64: Add missing driver-aarch64 dependencies
@ 2023-12-05 19:30 Andrew Carlotti
2023-12-09 18:42 ` Richard Sandiford
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Carlotti @ 2023-12-05 19:30 UTC (permalink / raw)
To: gcc-patches; +Cc: Richard Sandiford, Richard Earnshaw
Ok for master?
gcc/ChangeLog:
* config/aarch64/x-aarch64: Add missing dependencies.
diff --git a/gcc/config/aarch64/x-aarch64 b/gcc/config/aarch64/x-aarch64
index 3cf701a0a01ab00eaaafdfad14bd90ebbb1d498f..6fd638faaab7cb5bb2309d36d6dea2adf1fb8d32 100644
--- a/gcc/config/aarch64/x-aarch64
+++ b/gcc/config/aarch64/x-aarch64
@@ -1,3 +1,7 @@
driver-aarch64.o: $(srcdir)/config/aarch64/driver-aarch64.cc \
- $(CONFIG_H) $(SYSTEM_H)
+ $(CONFIG_H) $(SYSTEM_H) $(TM_H) $(CORETYPES_H) \
+ $(srcdir)/config/aarch64/aarch64-protos.h \
+ $(srcdir)/config/aarch64/aarch64-feature-deps.h \
+ $(srcdir)/config/aarch64/aarch64-cores.def \
+ $(srcdir)/config/aarch64/aarch64-arches.def
$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] aarch64: Add missing driver-aarch64 dependencies
2023-12-05 19:30 [PATCH] aarch64: Add missing driver-aarch64 dependencies Andrew Carlotti
@ 2023-12-09 18:42 ` Richard Sandiford
2023-12-13 14:47 ` [committed v2] " Andrew Carlotti
0 siblings, 1 reply; 4+ messages in thread
From: Richard Sandiford @ 2023-12-09 18:42 UTC (permalink / raw)
To: Andrew Carlotti; +Cc: gcc-patches, Richard Earnshaw
Andrew Carlotti <andrew.carlotti@arm.com> writes:
> Ok for master?
>
> gcc/ChangeLog:
>
> * config/aarch64/x-aarch64: Add missing dependencies.
>
>
> diff --git a/gcc/config/aarch64/x-aarch64 b/gcc/config/aarch64/x-aarch64
> index 3cf701a0a01ab00eaaafdfad14bd90ebbb1d498f..6fd638faaab7cb5bb2309d36d6dea2adf1fb8d32 100644
> --- a/gcc/config/aarch64/x-aarch64
> +++ b/gcc/config/aarch64/x-aarch64
> @@ -1,3 +1,7 @@
> driver-aarch64.o: $(srcdir)/config/aarch64/driver-aarch64.cc \
> - $(CONFIG_H) $(SYSTEM_H)
> + $(CONFIG_H) $(SYSTEM_H) $(TM_H) $(CORETYPES_H) \
> + $(srcdir)/config/aarch64/aarch64-protos.h \
> + $(srcdir)/config/aarch64/aarch64-feature-deps.h \
> + $(srcdir)/config/aarch64/aarch64-cores.def \
> + $(srcdir)/config/aarch64/aarch64-arches.def
The .def files are included in TM_H by:
TM_H += $(srcdir)/config/aarch64/aarch64-fusion-pairs.def \
$(srcdir)/config/aarch64/aarch64-tuning-flags.def \
$(srcdir)/config/aarch64/aarch64-option-extensions.def \
$(srcdir)/config/aarch64/aarch64-cores.def \
$(srcdir)/config/aarch64/aarch64-isa-modes.def \
$(srcdir)/config/aarch64/aarch64-arches.def
so they aren't strictly needed. If you'd prefer to include the
directly-included files anyway (can see the argument in favour of that),
then the list ought to include aarch64-option-extensions.def too.
OK whichever way you prefer.
Thanks,
Richard
> $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
^ permalink raw reply [flat|nested] 4+ messages in thread
* [committed v2] aarch64: Add missing driver-aarch64 dependencies
2023-12-09 18:42 ` Richard Sandiford
@ 2023-12-13 14:47 ` Andrew Carlotti
2023-12-13 18:03 ` Richard Sandiford
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Carlotti @ 2023-12-13 14:47 UTC (permalink / raw)
To: gcc-patches; +Cc: Richard Sandiford
On Sat, Dec 09, 2023 at 06:42:17PM +0000, Richard Sandiford wrote:
> Andrew Carlotti <andrew.carlotti@arm.com> writes:
> The .def files are included in TM_H by:
>
> TM_H += $(srcdir)/config/aarch64/aarch64-fusion-pairs.def \
> $(srcdir)/config/aarch64/aarch64-tuning-flags.def \
> $(srcdir)/config/aarch64/aarch64-option-extensions.def \
> $(srcdir)/config/aarch64/aarch64-cores.def \
> $(srcdir)/config/aarch64/aarch64-isa-modes.def \
> $(srcdir)/config/aarch64/aarch64-arches.def
They are included now, but only because you added them last week.
I've removed them in v2 of the patch, committed as below:
---
gcc/ChangeLog:
* config/aarch64/x-aarch64: Add missing dependencies.
diff --git a/gcc/config/aarch64/x-aarch64 b/gcc/config/aarch64/x-aarch64
index 3cf701a0a01ab00eaaafdfad14bd90ebbb1d498f..ee828c9af53a11885c2bcef8f112c0ebaf161c59 100644
--- a/gcc/config/aarch64/x-aarch64
+++ b/gcc/config/aarch64/x-aarch64
@@ -1,3 +1,5 @@
driver-aarch64.o: $(srcdir)/config/aarch64/driver-aarch64.cc \
- $(CONFIG_H) $(SYSTEM_H)
+ $(CONFIG_H) $(SYSTEM_H) $(TM_H) $(CORETYPES_H) \
+ $(srcdir)/config/aarch64/aarch64-protos.h \
+ $(srcdir)/config/aarch64/aarch64-feature-deps.h
$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [committed v2] aarch64: Add missing driver-aarch64 dependencies
2023-12-13 14:47 ` [committed v2] " Andrew Carlotti
@ 2023-12-13 18:03 ` Richard Sandiford
0 siblings, 0 replies; 4+ messages in thread
From: Richard Sandiford @ 2023-12-13 18:03 UTC (permalink / raw)
To: Andrew Carlotti; +Cc: gcc-patches
Andrew Carlotti <andrew.carlotti@arm.com> writes:
> On Sat, Dec 09, 2023 at 06:42:17PM +0000, Richard Sandiford wrote:
>> Andrew Carlotti <andrew.carlotti@arm.com> writes:
>> The .def files are included in TM_H by:
>>
>> TM_H += $(srcdir)/config/aarch64/aarch64-fusion-pairs.def \
>> $(srcdir)/config/aarch64/aarch64-tuning-flags.def \
>> $(srcdir)/config/aarch64/aarch64-option-extensions.def \
>> $(srcdir)/config/aarch64/aarch64-cores.def \
>> $(srcdir)/config/aarch64/aarch64-isa-modes.def \
>> $(srcdir)/config/aarch64/aarch64-arches.def
>
> They are included now, but only because you added them last week.
Ah, right. I'd already forgotten that I'd only done that recently, sorry...
> I've removed them in v2 of the patch, committed as below:
Thanks.
> ---
>
> gcc/ChangeLog:
>
> * config/aarch64/x-aarch64: Add missing dependencies.
>
>
> diff --git a/gcc/config/aarch64/x-aarch64 b/gcc/config/aarch64/x-aarch64
> index 3cf701a0a01ab00eaaafdfad14bd90ebbb1d498f..ee828c9af53a11885c2bcef8f112c0ebaf161c59 100644
> --- a/gcc/config/aarch64/x-aarch64
> +++ b/gcc/config/aarch64/x-aarch64
> @@ -1,3 +1,5 @@
> driver-aarch64.o: $(srcdir)/config/aarch64/driver-aarch64.cc \
> - $(CONFIG_H) $(SYSTEM_H)
> + $(CONFIG_H) $(SYSTEM_H) $(TM_H) $(CORETYPES_H) \
> + $(srcdir)/config/aarch64/aarch64-protos.h \
> + $(srcdir)/config/aarch64/aarch64-feature-deps.h
> $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-13 18:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05 19:30 [PATCH] aarch64: Add missing driver-aarch64 dependencies Andrew Carlotti
2023-12-09 18:42 ` Richard Sandiford
2023-12-13 14:47 ` [committed v2] " Andrew Carlotti
2023-12-13 18:03 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).