From: Richard Sandiford <richard.sandiford@arm.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
Richard Earnshaw <richard.earnshaw@arm.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Subject: Re: [PATCH] aarch64: testsuite: symbol-range compile only
Date: Tue, 21 Jun 2022 11:06:32 +0100 [thread overview]
Message-ID: <mptbkum72l3.fsf@arm.com> (raw)
In-Reply-To: <orbkumefo2.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Tue, 21 Jun 2022 02:42:05 -0300")
Alexandre Oliva <oliva@adacore.com> writes:
> On some of our embedded aarch64 targets, RAM size is too small for
> this test to fit. It doesn't look like this test requires linking,
> and if it does, the -tiny version may presumably get most of the
> coverage without going overboard in target system requirements.
Linking is valuable here because one of the likely failure modes
is an out-of-range relocation.
Could we instead have a new target selector for whether the memory
map includes xGB of RAM? E.g. maybe it could be along similar lines
to check_effective_target_simulator, reading an optional board
property that gives the RAM size.
Thanks,
Richard
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6. Ok to install?
>
>
> for gcc/testsuite/ChangeLog
>
> * gcc.target/aarch64/symbol-range.c: Compile only.
> ---
> gcc/testsuite/gcc.target/aarch64/symbol-range.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/symbol-range.c b/gcc/testsuite/gcc.target/aarch64/symbol-range.c
> index d8e82fa1b2829..cc68c19ca85d9 100644
> --- a/gcc/testsuite/gcc.target/aarch64/symbol-range.c
> +++ b/gcc/testsuite/gcc.target/aarch64/symbol-range.c
> @@ -1,4 +1,4 @@
> -/* { dg-do link } */
> +/* { dg-do compile } */
> /* { dg-options "-O3 -save-temps -mcmodel=small" } */
>
> char fixed_regs[0x80000000];
next prev parent reply other threads:[~2022-06-21 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 5:42 Alexandre Oliva
2022-06-21 10:06 ` Richard Sandiford [this message]
2022-06-22 5:14 ` Alexandre Oliva
2022-06-22 8:37 ` Richard Sandiford
2022-06-23 10:59 ` Alexandre Oliva
2022-06-24 2:33 ` Alexandre Oliva
2022-06-30 23:59 ` Hans-Peter Nilsson
2022-07-05 9:03 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptbkum72l3.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=oliva@adacore.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).