public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@adacore.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] aarch64: testsuite: symbol-range compile only
Date: Tue, 05 Jul 2022 06:03:22 -0300	[thread overview]
Message-ID: <or35fgq6cl.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <alpine.BSF.2.20.16.2206301955320.19699@arjuna.pair.com> (Hans-Peter Nilsson's message of "Thu, 30 Jun 2022 19:59:54 -0400 (EDT)")

On Jun 30, 2022, Hans-Peter Nilsson <hp@bitrange.com> wrote:

> On Thu, 23 Jun 2022, Alexandre Oliva via Gcc-patches wrote:
>> +proc check_effective_target_two_plus_gigs { } {
>> +    return [check_no_compiler_messages two_plus_gigs executable {
>> +	int dummy[0x80000000];

> Don't you mean "char" as in "char dummy[0x80000000]"?

Doh.  Of course!  Thanks for catching this.

Here's what I'm installing, regstrapped on x86_64-linux-gnu, also tested
on aarch64-rtems6.0 and ppc64-vx7r2.


testsuite: fix array type in two_plus_gigs test

The array element type for the two_plus_gigs test was mistakely put in
as int rather than char.


for  gcc/testsuite/ChangeLog

	* target-supports.exp (check_effective_target_two_plus_gigs):
	Fix array element type.  Reported by Hans-Peter Nilsson.

---
 gcc/testsuite/lib/target-supports.exp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 48c5dda6a1278..4ed7b25b9a4de 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -2909,7 +2909,7 @@ proc check_effective_target_le { } {
 
 proc check_effective_target_two_plus_gigs { } {
     return [check_no_compiler_messages two_plus_gigs executable {
-	int dummy[0x80000000];
+	char dummy[0x80000000];
 	int main () { return 0; }
     }]
 }


-- 
Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
   Free Software Activist                       GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>

      reply	other threads:[~2022-07-05  9:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  5:42 Alexandre Oliva
2022-06-21 10:06 ` Richard Sandiford
2022-06-22  5:14   ` Alexandre Oliva
2022-06-22  8:37     ` Richard Sandiford
2022-06-23 10:59       ` Alexandre Oliva
2022-06-24  2:33         ` Alexandre Oliva
2022-06-30 23:59         ` Hans-Peter Nilsson
2022-07-05  9:03           ` Alexandre Oliva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=or35fgq6cl.fsf@lxoliva.fsfla.org \
    --to=oliva@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hp@bitrange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).