From: Richard Sandiford <richard.sandiford@arm.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Fangrui Song <maskray@google.com>,
Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] testsuite: Add a test case for PR110729
Date: Thu, 20 Jul 2023 13:34:23 +0100 [thread overview]
Message-ID: <mptedl2kbhs.fsf@arm.com> (raw)
In-Reply-To: <a793b7d9-2235-f1c5-1591-92075b8c0b99@linux.ibm.com> (Kewen Lin's message of "Thu, 20 Jul 2023 18:13:25 +0800")
"Kewen.Lin" <linkw@linux.ibm.com> writes:
> Hi,
>
> As PR110729 reported, there was one issue for .section
> __patchable_function_entries with -ffunction-sections, that
> is we put the same symbol as link_to section symbol for all
> functions wrongly. The commit r13-4294 for PR99889 has
> fixed this with the corresponding label LPFE* which sits in
> the function_section.
>
> As Fangrui suggested[1], this patch is to add a bit more test
> coverage. I didn't find a good way to check all linked_to
> symbols are different, so I checked for LPFE[012] here.
>
> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624866.html
>
> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu
> P7/P8/P9 and powerpc64le-linux-gnu P9/P10.
>
> Is it ok for trunk?
>
> BR,
> Kewen
> -----
> PR testsuite/110729
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/pr110729.c: New test.
OK, thanks.
Richard
> ---
> gcc/testsuite/gcc.dg/pr110729.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 gcc/testsuite/gcc.dg/pr110729.c
>
> diff --git a/gcc/testsuite/gcc.dg/pr110729.c b/gcc/testsuite/gcc.dg/pr110729.c
> new file mode 100644
> index 00000000000..92dfd8ae000
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110729.c
> @@ -0,0 +1,29 @@
> +/* { dg-do compile { target { ! { nvptx*-*-* visium-*-* } } } } */
> +/* { dg-require-effective-target o_flag_in_section } */
> +/* { dg-options "-ffunction-sections -fpatchable-function-entry=2" } */
> +/* { dg-additional-options "-fno-pie" { target sparc*-*-* } } */
> +
> +/* Verify there are three different link_to symbols for three
> + .section __patchable_function_entries respectively. */
> +
> +int
> +f ()
> +{
> + return 1;
> +}
> +
> +int
> +g ()
> +{
> + return 2;
> +}
> +
> +int
> +h ()
> +{
> + return 3;
> +}
> +
> +/* { dg-final { scan-assembler-times {.section[\t ]*__patchable_function_entries,.*,\.LPFE0} 1 } } */
> +/* { dg-final { scan-assembler-times {.section[\t ]*__patchable_function_entries,.*,\.LPFE1} 1 } } */
> +/* { dg-final { scan-assembler-times {.section[\t ]*__patchable_function_entries,.*,\.LPFE2} 1 } } */
> --
> 2.39.3
next prev parent reply other threads:[~2023-07-20 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 10:13 Kewen.Lin
2023-07-20 12:34 ` Richard Sandiford [this message]
2023-07-21 5:22 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptedl2kbhs.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=maskray@google.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).