From: Richard Sandiford <richard.sandiford@arm.com>
To: "Torbjörn SVENSSON via Gcc-patches" <gcc-patches@gcc.gnu.org>
Cc: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>
Subject: Re: [PATCH v2] testsuite: Skip intrinsics test if arm
Date: Fri, 23 Sep 2022 18:24:27 +0100 [thread overview]
Message-ID: <mptedw2xaus.fsf@arm.com> (raw)
In-Reply-To: <20220920131337.843046-1-torbjorn.svensson@foss.st.com> (=?utf-8?Q?=22Torbj=C3=B6rn?= SVENSSON via Gcc-patches"'s message of "Tue, 20 Sep 2022 15:13:37 +0200")
Torbjörn SVENSSON via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> In the test cases, it's clearly written that intrinsics is not
> implemented on arm*. A simple xfail does not help since there are
> link error and that would cause an UNRESOLVED testcase rather than
> XFAIL.
> By changing to dg-skip-if, the entire test case is omitted.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace
> dg-xfail-if with gd-skip-if.
Typo: s/gd/dg/
OK with that change, thanks.
Richard
> * gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vld1x4.c: Likewise.
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> index 92a139bc523..f933102be47 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> -/* { dg-xfail-if "" { arm*-*-* } } */
> /* { dg-do run } */
> +/* { dg-skip-if "unsupported" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> index 6ddd507d9cf..b20dec061b5 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> -/* { dg-xfail-if "" { arm*-*-* } } */
> /* { dg-do run } */
> +/* { dg-skip-if "unsupported" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> index 451a0afc6aa..e59f845880e 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> -/* { dg-xfail-if "" { arm*-*-* } } */
> /* { dg-do run } */
> +/* { dg-skip-if "unsupported" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
next prev parent reply other threads:[~2022-09-23 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 13:13 Torbjörn SVENSSON
2022-09-23 17:24 ` Richard Sandiford [this message]
2022-09-26 7:41 ` Christophe Lyon
2022-09-26 8:17 ` Kyrylo Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptedw2xaus.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).