Re: [PATCH v2] machine descriptor: New compact syntax for insn and insn_split in Machine Descriptions.

[Richard Sandiford <richard.sandiford@arm.com>]

Richard Sandiford <richard.sandiford@arm.com> writes:
>> diff --git a/gcc/gensupport.h b/gcc/gensupport.h
>> index a1edfbd71908b6244b40f801c6c01074de56777e..7925e22ed418767576567cad583bddf83c0846b1 100644
>> --- a/gcc/gensupport.h
>> +++ b/gcc/gensupport.h
>> @@ -20,6 +20,7 @@ along with GCC; see the file COPYING3.  If not see
>>  #ifndef GCC_GENSUPPORT_H
>>  #define GCC_GENSUPPORT_H
>>  
>> +#include "hash-set.h"
>>  #include "read-md.h"
>>  
>>  struct obstack;
>> @@ -218,6 +219,8 @@ struct pattern_stats
>>    int num_operand_vars;
>>  };
>>  
>> +extern hash_set<rtx> compact_syntax;
>> +
>>  extern void get_pattern_stats (struct pattern_stats *ranges, rtvec vec);
>>  extern void compute_test_codes (rtx, file_location, char *);
>>  extern file_location get_file_location (rtx);
>> diff --git a/gcc/gensupport.cc b/gcc/gensupport.cc
>> index f9efc6eb7572a44b8bb154b0b22be3815bd0d244..f1d6b512356844da5d1dadbc69e08c16ef7a3abd 100644
>> --- a/gcc/gensupport.cc
>> +++ b/gcc/gensupport.cc
>> @@ -27,12 +27,17 @@
>>  #include "read-md.h"
>>  #include "gensupport.h"
>>  #include "vec.h"
>> +#include <string>
>> +#include <vector>
>> +#include <ctype.h>

Also: these need to be included via defining:

#define INCLUDE_STRING
#define INCLUDE_VECTOR

before system.h.  The ctype.h include should go away after s/isalpha/ISALPHA/.

>>  
>>  #define MAX_OPERANDS 40
>>  
>>  static rtx operand_data[MAX_OPERANDS];
>>  static rtx match_operand_entries_in_pattern[MAX_OPERANDS];
>>  static char used_operands_numbers[MAX_OPERANDS];
>> +/* List of entries which are part of the new syntax.  */
>> +hash_set<rtx> compact_syntax;
>
> Might as well make this static too, like the other vars.

Sorry, ignore that.  I somehow glazed over the header file changes
directly above...

Richard