From: Richard Sandiford <richard.sandiford@arm.com>
To: Richard Biener <rguenther@suse.de>
Cc: Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/3] Inline vect_get_max_nscalars_per_iter
Date: Wed, 14 Jun 2023 20:43:18 +0100 [thread overview]
Message-ID: <mpto7lhde3t.fsf@arm.com> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2306141345500.4723@jbgna.fhfr.qr> (Richard Biener's message of "Wed, 14 Jun 2023 13:46:54 +0000 (UTC)")
Richard Biener <rguenther@suse.de> writes:
> On Wed, 14 Jun 2023, Richard Sandiford wrote:
>
>> Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>> > The function is only meaningful for LOOP_VINFO_MASKS processing so
>> > inline it into the single use.
>> >
>> > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK?
>> >
>> > * tree-vect-loop.cc (vect_get_max_nscalars_per_iter): Inline
>> > into ...
>> > (vect_verify_full_masking): ... this.
>>
>> I think we did have a use for the separate function internally,
>> but obviously it was never submitted. Personally I'd prefer
>> to keep things as they are though.
>
> OK - after 3/3 it's no longer "generic" (it wasn't before,
> it doesn't inspect the _len groups either), it's only meaningful
> for WHILE_ULT style analysis.
Ah, yeah, that's fair. Sorry, I hadn't seen the rgc_vec/rgc_map
thing when I wrote the above.
So yeah, please go ahead.
Thanks,
Richard
>
>>
>>
>> > ---
>> > gcc/tree-vect-loop.cc | 22 ++++++----------------
>> > 1 file changed, 6 insertions(+), 16 deletions(-)
>> >
>> > diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc
>> > index ace9e759f5b..a9695e5b25d 100644
>> > --- a/gcc/tree-vect-loop.cc
>> > +++ b/gcc/tree-vect-loop.cc
>> > @@ -1117,20 +1117,6 @@ can_produce_all_loop_masks_p (loop_vec_info loop_vinfo, tree cmp_type)
>> > return true;
>> > }
>> >
>> > -/* Calculate the maximum number of scalars per iteration for every
>> > - rgroup in LOOP_VINFO. */
>> > -
>> > -static unsigned int
>> > -vect_get_max_nscalars_per_iter (loop_vec_info loop_vinfo)
>> > -{
>> > - unsigned int res = 1;
>> > - unsigned int i;
>> > - rgroup_controls *rgm;
>> > - FOR_EACH_VEC_ELT (LOOP_VINFO_MASKS (loop_vinfo), i, rgm)
>> > - res = MAX (res, rgm->max_nscalars_per_iter);
>> > - return res;
>> > -}
>> > -
>> > /* Calculate the minimum precision necessary to represent:
>> >
>> > MAX_NITERS * FACTOR
>> > @@ -1210,8 +1196,6 @@ static bool
>> > vect_verify_full_masking (loop_vec_info loop_vinfo)
>> > {
>> > unsigned int min_ni_width;
>> > - unsigned int max_nscalars_per_iter
>> > - = vect_get_max_nscalars_per_iter (loop_vinfo);
>> >
>> > /* Use a normal loop if there are no statements that need masking.
>> > This only happens in rare degenerate cases: it means that the loop
>> > @@ -1219,6 +1203,12 @@ vect_verify_full_masking (loop_vec_info loop_vinfo)
>> > if (LOOP_VINFO_MASKS (loop_vinfo).is_empty ())
>> > return false;
>> >
>> > + /* Calculate the maximum number of scalars per iteration for every rgroup. */
>> > + unsigned int max_nscalars_per_iter = 1;
>> > + for (auto rgm : LOOP_VINFO_MASKS (loop_vinfo))
>> > + max_nscalars_per_iter
>> > + = MAX (max_nscalars_per_iter, rgm.max_nscalars_per_iter);
>> > +
>> > /* Work out how many bits we need to represent the limit. */
>> > min_ni_width
>> > = vect_min_prec_for_max_niters (loop_vinfo, max_nscalars_per_iter);
>>
next prev parent reply other threads:[~2023-06-14 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614114802.BED073858288@sourceware.org>
2023-06-14 13:21 ` Richard Sandiford
2023-06-14 13:46 ` Richard Biener
2023-06-14 19:43 ` Richard Sandiford [this message]
2023-06-14 11:47 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpto7lhde3t.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).