From: Richard Sandiford <richard.sandiford@arm.com>
To: Michael Collison <collison@rivosinc.com>
Cc: "gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] vect: Verify that GET_MODE_NUNITS is greater than one.
Date: Fri, 31 Mar 2023 10:58:02 +0100 [thread overview]
Message-ID: <mpto7o9tf85.fsf@arm.com> (raw)
In-Reply-To: <20230314215256.4153026-1-collison@rivosinc.com> (Michael Collison's message of "Tue, 14 Mar 2023 21:52:56 +0000")
Michael Collison <collison@rivosinc.com> writes:
> While working on autovectorizing for the RISCV port I encountered an issue
> where can_duplicate_and_interleave_p assumes that GET_MODE_NUNITS is a
> evenly divisible by two. The RISC-V target has vector modes (e.g. VNx1DImode),
> where GET_MODE_NUNITS is equal to one.
>
> Tested on RISCV and x86_64-linux-gnu. Okay?
>
> 2023-03-09 Michael Collison <collison@rivosinc.com>
>
> * tree-vect-slp.cc (can_duplicate_and_interleave_p):
> Check that GET_MODE_NUNITS is greater than one.
> ---
> gcc/tree-vect-slp.cc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
> index 9a4e000925e..add58113fa8 100644
> --- a/gcc/tree-vect-slp.cc
> +++ b/gcc/tree-vect-slp.cc
> @@ -426,7 +426,8 @@ can_duplicate_and_interleave_p (vec_info *vinfo, unsigned int count,
> if (vector_type
> && VECTOR_MODE_P (TYPE_MODE (vector_type))
> && known_eq (GET_MODE_SIZE (TYPE_MODE (vector_type)),
> - GET_MODE_SIZE (base_vector_mode)))
> + GET_MODE_SIZE (base_vector_mode))
> + && known_gt (GET_MODE_NUNITS (TYPE_MODE (vector_type)), 1))
> {
> /* Try fusing consecutive sequences of COUNT / NVECTORS elements
> together into elements of type INT_TYPE and using the result
FWIW, I think it'd better to remove:
poly_int64 half_nelts = exact_div (nelts, 2);
declare:
poly_uint64 half_nelts;
before the if condition, and use:
&& multiple_p (GET_MODE_NUNITS (TYPE_MODE (vector_type)),
2, &half_nelts)
instead of the known_gt. In other words, now that we can't assert
the exact_div, we should check it (using multiple_p) instead.
Thanks,
Richard
next prev parent reply other threads:[~2023-03-31 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:52 Michael Collison
2023-03-19 16:58 ` Jeff Law
2023-03-31 9:58 ` Richard Sandiford [this message]
2023-04-22 0:23 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpto7o9tf85.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=collison@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).